Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 958313002: [CleanUp] Move PowerApiManager to power_api and Rename (Closed)

Created:
5 years, 9 months ago by zhuoyu.qian
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CleanUp] Move PowerApiManager to power_api and Rename As the TODO in power_api_manager.h by derat@, move PowerApiManager to power_api and rename to PowerAPI. BUG= R=derat@chromium.org Committed: https://crrev.com/dc74c6d5cf065315e5e7e747edec386ab10efff3 Cr-Commit-Position: refs/heads/master@{#318816}

Patch Set 1 #

Total comments: 4

Patch Set 2 : rename to PowerAPI #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -246 lines) Patch
M chrome/browser/apps/ephemeral_app_browsertest.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/power_policy_browsertest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/browser_context_keyed_service_factories.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/power/power_api.h View 1 2 chunks +84 lines, -0 lines 0 comments Download
M extensions/browser/api/power/power_api.cc View 1 1 chunk +108 lines, -4 lines 0 comments Download
D extensions/browser/api/power/power_api_manager.h View 1 chunk +0 lines, -98 lines 0 comments Download
D extensions/browser/api/power/power_api_manager.cc View 1 chunk +0 lines, -116 lines 0 comments Download
M extensions/browser/api/power/power_api_unittest.cc View 1 9 chunks +17 lines, -17 lines 0 comments Download
M extensions/extensions.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
zhuoyu.qian
PHAL, Thank you!
5 years, 9 months ago (2015-02-27 07:09:29 UTC) #2
Daniel Erat
thanks! https://codereview.chromium.org/958313002/diff/1/chrome/browser/extensions/browser_context_keyed_service_factories.cc File chrome/browser/extensions/browser_context_keyed_service_factories.cc (right): https://codereview.chromium.org/958313002/diff/1/chrome/browser/extensions/browser_context_keyed_service_factories.cc#newcode124 chrome/browser/extensions/browser_context_keyed_service_factories.cc:124: extensions::PowerApi::GetFactoryInstance(); mind going with PowerAPI instead, since that ...
5 years, 9 months ago (2015-02-27 13:58:39 UTC) #4
zhuoyu.qian
Patch has updated according Daniel Erat's comments above, PHAL. Thank you. https://codereview.chromium.org/958313002/diff/1/chrome/browser/extensions/browser_context_keyed_service_factories.cc File chrome/browser/extensions/browser_context_keyed_service_factories.cc (right): ...
5 years, 9 months ago (2015-02-28 01:46:43 UTC) #5
Daniel Erat
lgtm
5 years, 9 months ago (2015-02-28 02:59:01 UTC) #6
Ken Rockot(use gerrit already)
lgtm
5 years, 9 months ago (2015-02-28 17:48:58 UTC) #7
zhuoyu.qian
Hi scheib: I'd like you to do a code review for chrome/browser/apps/ephemeral_app_browsertest.cc
5 years, 9 months ago (2015-03-02 01:42:10 UTC) #8
scheib
chrome/browser/apps/ephemeral_app_browsertest.cc LGTM
5 years, 9 months ago (2015-03-02 17:01:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/958313002/20001
5 years, 9 months ago (2015-03-03 00:06:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/958313002/20001
5 years, 9 months ago (2015-03-03 00:55:05 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-03 01:48:33 UTC) #15
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 01:49:15 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dc74c6d5cf065315e5e7e747edec386ab10efff3
Cr-Commit-Position: refs/heads/master@{#318816}

Powered by Google App Engine
This is Rietveld 408576698