Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 958283002: X87: Stop using HeapType in IC and Crankshaft. (Closed)

Created:
5 years, 9 months ago by chunyang.dai
Modified:
5 years, 9 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Stop using HeapType in IC and Crankshaft. port 119cb5661724006b736fcb6484258c752125e372 (r26696). original commit message: Stop using HeapType in IC and Crankshaft BUG= R=weiliang.lin@intel.com Committed: https://chromium.googlesource.com/v8/v8/+/cd87f25a2ee3f6f2dd5a65786c72f213646c476f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -18 lines) Patch
M src/ic/x87/handler-compiler-x87.cc View 6 chunks +10 lines, -12 lines 0 comments Download
M src/ic/x87/ic-compiler-x87.cc View 3 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 9 months ago (2015-02-27 05:59:26 UTC) #2
Weiliang
lgtm
5 years, 9 months ago (2015-02-27 06:59:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/958283002/1
5 years, 9 months ago (2015-02-27 06:59:40 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cd87f25a2ee3f6f2dd5a65786c72f213646c476f Cr-Commit-Position: refs/heads/master@{#26903}
5 years, 9 months ago (2015-02-27 07:02:40 UTC) #6
chunyang.dai
5 years, 9 months ago (2015-02-27 07:02:48 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cd87f25a2ee3f6f2dd5a65786c72f213646c476f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698