Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 958233004: [NaCl SDK] Remove gtest_main.cc from libgtest (Closed)

Created:
5 years, 9 months ago by Sam Clegg
Modified:
5 years, 9 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Remove gtest_main.cc from libgtest This file is not supposed to be part of libgtest but in its own library called libgtest_main.a. Its also fairly useless right now in the context of PPAPI (all our gtest examples currently use ppapi_simple and define their own entry point). In the long run we could re-enable this if it becomes useful, but really we should probably just remove the gtest libraries from the SDK completely since shipping gtest in library form is not recommended practice. Committed: https://crrev.com/862ca287ca57dabc1f021a1ab0cdfcb13269d8d7 Cr-Commit-Position: refs/heads/master@{#318932}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M native_client_sdk/src/libraries/gtest/library.dsc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Sam Clegg
5 years, 9 months ago (2015-03-02 19:55:52 UTC) #2
binji
This Windows failure seems like it shouldn't be caused by your change, but it is ...
5 years, 9 months ago (2015-03-03 19:03:40 UTC) #3
binji
Sounds like it is unrelated. lgtm
5 years, 9 months ago (2015-03-03 19:11:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/958233004/1
5 years, 9 months ago (2015-03-03 19:52:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 19:55:52 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 19:57:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/862ca287ca57dabc1f021a1ab0cdfcb13269d8d7
Cr-Commit-Position: refs/heads/master@{#318932}

Powered by Google App Engine
This is Rietveld 408576698