Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issue 958133005: Fix custom launcher pages showing when setEnabled(false) is called. (Closed)

Created:
5 years, 9 months ago by calamity
Modified:
5 years, 9 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@tab_focus_SOLVED
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix custom launcher pages showing when setEnabled(false) is called. This CL fixes an issue where the custom launcher page would still be shown when the app list was opened even when setEnabled(false) was called. BUG=462444 Committed: https://crrev.com/7d3292e1f794939ba322524b3871280041e27c22 Cr-Commit-Position: refs/heads/master@{#318650}

Patch Set 1 #

Total comments: 2

Patch Set 2 : make into minimal diff fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/app_list/views/app_list_main_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
calamity
5 years, 9 months ago (2015-02-27 05:40:50 UTC) #2
Matt Giuca
lgtm
5 years, 9 months ago (2015-02-27 06:09:36 UTC) #3
Matt Giuca
https://codereview.chromium.org/958133005/diff/1/ui/app_list/views/app_list_main_view.cc File ui/app_list/views/app_list_main_view.cc (right): https://codereview.chromium.org/958133005/diff/1/ui/app_list/views/app_list_main_view.cc#newcode258 ui/app_list/views/app_list_main_view.cc:258: if (ShouldShowCustomLauncherPage()) { Could you get this to work ...
5 years, 9 months ago (2015-02-27 06:11:33 UTC) #4
calamity
https://codereview.chromium.org/958133005/diff/1/ui/app_list/views/app_list_main_view.cc File ui/app_list/views/app_list_main_view.cc (right): https://codereview.chromium.org/958133005/diff/1/ui/app_list/views/app_list_main_view.cc#newcode258 ui/app_list/views/app_list_main_view.cc:258: if (ShouldShowCustomLauncherPage()) { On 2015/02/27 06:11:33, Matt Giuca wrote: ...
5 years, 9 months ago (2015-03-02 02:39:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/958133005/20001
5 years, 9 months ago (2015-03-02 04:14:45 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-02 05:09:14 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 05:09:42 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7d3292e1f794939ba322524b3871280041e27c22
Cr-Commit-Position: refs/heads/master@{#318650}

Powered by Google App Engine
This is Rietveld 408576698