Fix touch in software mirror mode when there is no internal display

Fix touch in software mirror mode when there is no internal display

BUG=462382
TEST=Manual, see bug

Committed: https://crrev.com/94b8fe46a0abf285a0c39cd36007de0236dd7e97
Cr-Commit-Position: refs/heads/master@{#318763}

[pkotwicz, 2015-02-26 22:40:45]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2015-02-26 22:41:26]

pkotwicz@chromium.org changed reviewers:
+ oshima@chromium.org

[pkotwicz, 2015-02-26 22:41:27]

Oshima, PTAL

[oshima, 2015-02-27 22:13:54]

https://codereview.chromium.org/958123003/diff/20001/ash/touch/touch_transfor...
File ash/touch/touch_transformer_controller.cc (right):

https://codereview.chromium.org/958123003/diff/20001/ash/touch/touch_transfor...
ash/touch/touch_transformer_controller.cc:208: : display2;
primary display can be external on the device that have internal display. I
think you need to handle both cases (use internal, or use primary when no
internal)

[pkotwicz, 2015-03-01 01:51:14]

Oshima, can you please take another look?

https://codereview.chromium.org/958123003/diff/20001/ash/touch/touch_transfor...
File ash/touch/touch_transformer_controller.cc (right):

https://codereview.chromium.org/958123003/diff/20001/ash/touch/touch_transfor...
ash/touch/touch_transformer_controller.cc:208: : display2;
That is true. However, in software mirror mode, if the device has an internal
display, the internal display is guaranteed to be the primary display.

The primary display is updated in DisplayController::OnDisplayRemoved()
In software mirror mode, |DisplayManager::displays_| has just one entry

[pkotwicz, 2015-03-01 03:32:50]

https://codereview.chromium.org/958123003/diff/20001/ash/touch/touch_transfor...
File ash/touch/touch_transformer_controller.cc (right):

https://codereview.chromium.org/958123003/diff/20001/ash/touch/touch_transfor...
ash/touch/touch_transformer_controller.cc:208: : display2;
Even if the internal display is not the primary display in software mirror mode
and the device has an internal display, this code does the right thing.

On Ozone, the internal display is always the primary display but for very subtle
reasons. Which display is the source display / primary display depends on:
- The display IDs of both displays
- The order of |NativeDisplayDelegateDri::cached_displays_|
See
https://code.google.com/p/chromium/codesearch#chromium/src/ash/display/displa...

[oshima, 2015-03-02 20:12:58]

On 2015/03/01 03:32:50, pkotwicz wrote:
>
https://codereview.chromium.org/958123003/diff/20001/ash/touch/touch_transfor...
> File ash/touch/touch_transformer_controller.cc (right):
> 
>
https://codereview.chromium.org/958123003/diff/20001/ash/touch/touch_transfor...
> ash/touch/touch_transformer_controller.cc:208: : display2;
> Even if the internal display is not the primary display in software mirror
mode
> and the device has an internal display, this code does the right thing.
> 
> On Ozone, the internal display is always the primary display but for very
subtle
> reasons. Which display is the source display / primary display depends on:
> - The display IDs of both displays
> - The order of |NativeDisplayDelegateDri::cached_displays_|
> See
>
https://code.google.com/p/chromium/codesearch#chromium/src/ash/display/displa...

Ah, you're right. lgtm

[pkotwicz, 2015-03-02 20:22:51]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2015-03-02 20:24:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/958123003/20001

[commit-bot: I haz the power, 2015-03-02 21:14:53]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2015-03-02 21:15:47]

Patchset 1 (id:??) landed as
https://crrev.com/94b8fe46a0abf285a0c39cd36007de0236dd7e97
Cr-Commit-Position: refs/heads/master@{#318763}