Issue 958113004: Revert of Invalidate the global property cell when converting from data to accessor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 958113004: Revert of Invalidate the global property cell when converting from data to accessor. (Closed)

Created:
5 years, 10 months ago by Michael Achenbach

Modified:
5 years, 10 months ago

Reviewers:
Toon Verwaest, Jakob Kummerow

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of Invalidate the global property cell when converting from data to accessor. (patchset #1 id:1 of https://codereview.chromium.org/961003002/) Reason for revert: Breaks gc stress, e.g.: http://build.chromium.org/p/client.v8/builders/V8%20GC%20Stress%20-%201/builds/2322 Original issue's description: > Invalidate the global property cell when converting from data to accessor. > > BUG= > TBR=jkummerow@chromium.org, > > Committed: https://crrev.com/6a12dc240b1faffa500ff269077d832ecc74239d > Cr-Commit-Position: refs/heads/master@{#26896} TBR=jkummerow@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/885a88166d3868054958a616b844d4b6342c9bb9 Cr-Commit-Position: refs/heads/master@{#26899}

Created: 5 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -26 lines)			Patch
M	src/ic/handler-compiler.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.cc	View	2 chunks	+7 lines, -10 lines	0 comments	Download
D	test/mjsunit/regress/convert-global-data-to-accessor.js	View	1 chunk	+0 lines, -15 lines	0 comments	Download

Total messages: 4 (0 generated)

Michael Achenbach

Created Revert of Invalidate the global property cell when converting from data to accessor.

5 years, 10 months ago (2015-02-26 21:01:47 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/958113004/1

5 years, 10 months ago (2015-02-26 21:02:49 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-26 21:03:29 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/885a88166d3868054958a616b844d4b6342c9bb9
Cr-Commit-Position: refs/heads/master@{#26899}