content/browser/loader/navigation_url_loader_impl.cc - Issue 958083002: PlzNavigate: Show error pages when the navigation failed before commit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/navigation_url_loader_impl.cc

Issue 958083002: PlzNavigate: Show error pages when the navigation failed before commit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@support-data-urls

Patch Set: Updated test Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/loader/navigation_url_loader_impl.h ('k') | content/browser/loader/navigation_url_loader_impl_core.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/navigation_url_loader_impl.cc

diff --git a/content/browser/loader/navigation_url_loader_impl.cc b/content/browser/loader/navigation_url_loader_impl.cc

index 658c4dc775f24983f762d2a4b318a3d442b0b918..4082489fea1cb2d91e5b6267107e6e9b92a8ded1 100644

--- a/content/browser/loader/navigation_url_loader_impl.cc

+++ b/content/browser/loader/navigation_url_loader_impl.cc

@@ -64,10 +64,11 @@ void NavigationURLLoaderImpl::NotifyResponseStarted(

delegate_->OnResponseStarted(response, body.Pass());

}

-void NavigationURLLoaderImpl::NotifyRequestFailed(int net_error) {

+void NavigationURLLoaderImpl::NotifyRequestFailed(bool in_cache,

+ int net_error) {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

- delegate_->OnRequestFailed(net_error);

+ delegate_->OnRequestFailed(in_cache, net_error);

}

void NavigationURLLoaderImpl::NotifyRequestStarted(base::TimeTicks timestamp) {

« no previous file with comments | « content/browser/loader/navigation_url_loader_impl.h ('k') | content/browser/loader/navigation_url_loader_impl_core.h » ('j') | no next file with comments »