content/browser/loader/navigation_resource_handler.cc - Issue 958083002: PlzNavigate: Show error pages when the navigation failed before commit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/navigation_resource_handler.cc

Issue 958083002: PlzNavigate: Show error pages when the navigation failed before commit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@support-data-urls

Patch Set: Updated test Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/browser/loader/navigation_url_loader_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/navigation_resource_handler.cc

diff --git a/content/browser/loader/navigation_resource_handler.cc b/content/browser/loader/navigation_resource_handler.cc

index 393b295776e4a935a117c2abece15d16d7f37fae..ec6119a830cd7485aed3c9e6e739c184887bbe83 100644

--- a/content/browser/loader/navigation_resource_handler.cc

+++ b/content/browser/loader/navigation_resource_handler.cc

@@ -29,7 +29,7 @@ NavigationResourceHandler::NavigationResourceHandler(

NavigationResourceHandler::~NavigationResourceHandler() {

if (core_) {

- core_->NotifyRequestFailed(net::ERR_ABORTED);

+ core_->NotifyRequestFailed(false, net::ERR_ABORTED);

DetachFromCore();

}

@@ -131,7 +131,8 @@ void NavigationResourceHandler::OnResponseCompleted(

if (core_) {

DCHECK_NE(net::OK, status.error());

- core_->NotifyRequestFailed(status.error());

+ core_->NotifyRequestFailed(request()->response_info().was_cached,

+ status.error());

DetachFromCore();

}

« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/browser/loader/navigation_url_loader_delegate.h » ('j') | no next file with comments »