Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: content/renderer/render_frame_impl.h

Issue 958083002: PlzNavigate: Show error pages when the navigation failed before commit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@support-data-urls
Patch Set: Changed the way replace is computed for failed loads Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.h
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index 47c9620b44205b392a3490b2ffa6c6c4fdeb6d09..3ca3fdeac8f50555527a0bf4dd8eac8145a075c6 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -657,6 +657,10 @@ class CONTENT_EXPORT RenderFrameImpl
const GURL& stream_url,
const CommonNavigationParams& common_params,
const RequestNavigationParams& request_params);
+ void OnFailedNavigation(const CommonNavigationParams& common_params,
+ const RequestNavigationParams& request_params,
+ bool has_stale_copy_in_cache,
+ int error_code);
// Virtual since overridden by WebTestProxy for layout tests.
virtual blink::WebNavigationPolicy DecidePolicyForNavigation(
@@ -736,6 +740,15 @@ class CONTENT_EXPORT RenderFrameImpl
void LoadDataURL(const CommonNavigationParams& params,
blink::WebFrame* frame);
+ // Sends a proper FrameHostMsg_DidFailProvisionalLoadWithError_Params IPC for
+ // the failed request |request|.
+ void SendFailedProvisionalLoad(const blink::WebURLRequest& request,
+ const blink::WebURLError& error,
+ blink::WebLocalFrame* frame);
+
+ bool ShouldDisplayErrorPageForFailedLoad(int error_code,
+ const GURL& unreachable_url);
+
// Returns the URL being loaded by the |frame_|'s request.
GURL GetLoadingUrl() const;

Powered by Google App Engine
This is Rietveld 408576698