content/browser/loader/resource_dispatcher_host_impl.cc - Issue 958083002: PlzNavigate: Show error pages when the navigation failed before commit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/resource_dispatcher_host_impl.cc

Issue 958083002: PlzNavigate: Show error pages when the navigation failed before commit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@support-data-urls

Patch Set: Changed the way replace is computed for failed loads Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/loader/navigation_url_loader_unittest.cc ('k') | content/child/blink_platform_impl.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/resource_dispatcher_host_impl.cc

diff --git a/content/browser/loader/resource_dispatcher_host_impl.cc b/content/browser/loader/resource_dispatcher_host_impl.cc

index 4f9f2f733053606a83d5d92f5180221d3b1caf32..31aa728216b858358b5076510e74e8525f8691ab 100644

--- a/content/browser/loader/resource_dispatcher_host_impl.cc

+++ b/content/browser/loader/resource_dispatcher_host_impl.cc

@@ -1865,7 +1865,7 @@ void ResourceDispatcherHostImpl::BeginNavigationRequest(

info.common_params.url,

resource_type,

resource_context))) {

- loader->NotifyRequestFailed(net::ERR_ABORTED);

+ loader->NotifyRequestFailed(false, net::ERR_ABORTED);

return;

}

« no previous file with comments | « content/browser/loader/navigation_url_loader_unittest.cc ('k') | content/child/blink_platform_impl.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')