Issue 958053003: Removed funky Maybe constructor and made fields private.

Issue 958053003: Removed funky Maybe constructor and made fields private. (Closed)

Created:
5 years, 9 months ago by Sven Panne

Modified:
5 years, 9 months ago

Reviewers:
dcarney

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Removed funky Maybe constructor and made fields private. BUG=v8:3929 LOG=y R=dcarney@chromium.org Committed: https://crrev.com/602d0dab9380c4bae92f58e00ef35661f541d5b3 Cr-Commit-Position: refs/heads/master@{#26937}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+185 lines, -223 lines)			Patch
M	include/v8.h	View	2 chunks	+14 lines, -9 lines	0 comments	Download
M	src/api.cc	View	9 chunks	+19 lines, -19 lines	0 comments	Download
M	src/api-natives.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/ast.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/contexts.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/hydrogen.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/hydrogen-representation-changes.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/i18n.cc	View	6 chunks	+12 lines, -12 lines	0 comments	Download
M	src/ic/ic-state.cc	View	6 chunks	+18 lines, -20 lines	0 comments	Download
M	src/objects.cc	View	19 chunks	+37 lines, -36 lines	0 comments	Download
M	src/objects-inl.h	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/runtime/runtime-array.cc	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	src/runtime/runtime-debug.cc	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	src/runtime/runtime-object.cc	View	8 chunks	+16 lines, -16 lines	0 comments	Download
M	src/runtime/runtime-scopes.cc	View	4 chunks	+8 lines, -8 lines	0 comments	Download
M	test/cctest/test-api.cc	View	4 chunks	+4 lines, -8 lines	0 comments	Download
M	test/cctest/test-heap.cc	View	5 chunks	+19 lines, -54 lines	0 comments	Download
M	test/cctest/test-mark-compact.cc	View	3 chunks	+3 lines, -6 lines	0 comments	Download

Total messages: 5 (1 generated)

Sven Panne

Committed patchset #1 (id:1) manually as 602d0dab9380c4bae92f58e00ef35661f541d5b3 (presubmit successful).

5 years, 9 months ago (2015-03-02 12:22:44 UTC) #4

commit-bot: I haz the power

5 years, 9 months ago (2015-03-02 12:22:46 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/602d0dab9380c4bae92f58e00ef35661f541d5b3
Cr-Commit-Position: refs/heads/master@{#26937}