Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: tools/dm_flags.py

Issue 958033004: Test msaa on bots using dm. 4 samples for Android, 16 elsewhere (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Rebase off Mike's patch and add exclusions Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dm_flags.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dm_flags.py
diff --git a/tools/dm_flags.py b/tools/dm_flags.py
index 985a62adf573e2cad0110187b64924cd942bb368..a7ed8ca7afaf804f93bd63633fea4c74f68c631c 100755
--- a/tools/dm_flags.py
+++ b/tools/dm_flags.py
@@ -22,7 +22,16 @@ cov_start = lineno()+1 # We care about coverage starting just past this def.
def get_args(bot):
args = []
- configs = ['565', '8888', 'gpu', 'nvprmsaa4']
+ configs = ['565', '8888', 'gpu']
+ # The S4 crashes and the NP produces a long error stream when we run with
+ # MSAA.
+ if ('GalaxyS4' not in bot and
+ 'NexusPlayer' not in bot):
+ if 'Android' in bot:
+ configs.extend(['msaa4', 'nvprmsaa4'])
+ else:
+ configs.extend(['msaa16', 'nvprmsaa16'])
+
# Xoom and NP are running out of RAM when we run all these modes. skia:3255
if ('Xoom' not in bot and
'NexusPlayer' not in bot):
« no previous file with comments | « tools/dm_flags.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698