Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 958023002: Store weak cell cache for map in the map itself. (Closed)

Created:
5 years, 10 months ago by ulan
Modified:
5 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Store weak cell cache for map in the map itself. BUG= Committed: https://crrev.com/250dd1ed5a79b54eeb4409c9f0d52d9cc00cda6f Cr-Commit-Position: refs/heads/master@{#26891}

Patch Set 1 #

Patch Set 2 : Fix verification of normalized map #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M src/factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/heap.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/objects.h View 4 chunks +6 lines, -4 lines 0 comments Download
M src/objects.cc View 1 3 chunks +7 lines, -9 lines 0 comments Download
M src/objects-inl.h View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
ulan
PTAL. Besides simplifying the code, this saves ~150kb for the google inbox website.
5 years, 10 months ago (2015-02-26 13:01:51 UTC) #2
Toon Verwaest
lgtm
5 years, 10 months ago (2015-02-26 14:44:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/958023002/20001
5 years, 10 months ago (2015-02-26 16:07:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/958023002/20001
5 years, 10 months ago (2015-02-26 16:32:04 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-26 18:35:57 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 18:36:14 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/250dd1ed5a79b54eeb4409c9f0d52d9cc00cda6f
Cr-Commit-Position: refs/heads/master@{#26891}

Powered by Google App Engine
This is Rietveld 408576698