Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1153)

Issue 957983002: Change DCHECKs to CHECKs to investigate a crash when aborting in Files app. (Closed)

Created:
5 years, 9 months ago by mtomasz
Modified:
5 years, 9 months ago
Reviewers:
fukino
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change DCHECKs to CHECKs to investigate a crash when aborting in Files app. This crash happens often, but I'm unable to reproduce it, so can't find the root cause. The suspects are corruption of memory which are protected with DCHECKs. TEST=Not related. BUG=454310 Committed: https://crrev.com/56b45a9336e040f95ff0e0977d07ce42c87b283a Cr-Commit-Position: refs/heads/master@{#318217}

Patch Set 1 #

Patch Set 2 : Cleaned up. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/browser/chromeos/file_system_provider/queue.cc View 1 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/throttled_file_system.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
mtomasz
@hirono: PTAL. We need to merge it to beta asap.
5 years, 9 months ago (2015-02-26 08:49:35 UTC) #2
mtomasz
@fukino: PTAL. Thanks.
5 years, 9 months ago (2015-02-26 11:12:30 UTC) #5
fukino
lgtm. Thanks!
5 years, 9 months ago (2015-02-26 11:13:25 UTC) #6
mtomasz
Thanks!
5 years, 9 months ago (2015-02-26 11:13:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/957983002/20001
5 years, 9 months ago (2015-02-26 11:14:09 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-02-26 11:54:23 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-02-26 11:55:17 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/56b45a9336e040f95ff0e0977d07ce42c87b283a
Cr-Commit-Position: refs/heads/master@{#318217}

Powered by Google App Engine
This is Rietveld 408576698