Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: tests/lib/typed_data/native_interceptor_no_own_method_to_intercept_test.dart

Issue 957973006: dart2js: don't emit unneeded native info. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/typed_data/int32x4_test.dart ('k') | tests/lib/typed_data/setRange_1_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/typed_data/native_interceptor_no_own_method_to_intercept_test.dart
diff --git a/runtime/tests/vm/dart/snapshot_version_test.dart b/tests/lib/typed_data/native_interceptor_no_own_method_to_intercept_test.dart
similarity index 50%
copy from runtime/tests/vm/dart/snapshot_version_test.dart
copy to tests/lib/typed_data/native_interceptor_no_own_method_to_intercept_test.dart
index 2dcde10186d899773cba16b7ec3e55ebb2101b76..4b5d31ceed6e83aa338bcf7ce481453939868569 100644
--- a/runtime/tests/vm/dart/snapshot_version_test.dart
+++ b/tests/lib/typed_data/native_interceptor_no_own_method_to_intercept_test.dart
@@ -2,13 +2,15 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-import "dart:io";
import "package:expect/expect.dart";
+import 'dart:typed_data';
+
+@NoInline()
+use(s) => s;
main() {
- var result = Process.runSync(Platform.executable,
- [Platform.script.resolve('./bad_snapshot').toFilePath()]);
- print("=== stdout ===\n ${result.stdout}");
- print("=== stderr ===\n ${result.stderr}");
- Expect.equals(253, result.exitCode);
+ // In dart2js ByteData should have an interceptor so that it doesn't end up
+ // as an unknown JS object.
+ // This test is just to make sure that dart2js doesn't crash.
+ use(new ByteData(1).toString());
}
« no previous file with comments | « tests/lib/typed_data/int32x4_test.dart ('k') | tests/lib/typed_data/setRange_1_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698