Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder.dart

Issue 957973006: dart2js: don't emit unneeded native info. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/program_builder.dart
diff --git a/pkg/compiler/lib/src/js_emitter/program_builder.dart b/pkg/compiler/lib/src/js_emitter/program_builder.dart
index 2d22ead02315ee95bb458efb7d9fb5dbc76f3817..69f2fc603232661a8fd7f279ca031a8a4237b4df 100644
--- a/pkg/compiler/lib/src/js_emitter/program_builder.dart
+++ b/pkg/compiler/lib/src/js_emitter/program_builder.dart
@@ -117,18 +117,20 @@ class ProgramBuilder {
_markEagerClasses();
- bool containsNativeClasses =
- nativeClasses.length != _unneededNativeClasses.length;
-
List<Holder> holders = _registry.holders.toList(growable: false);
+ bool needsNativeSupport = _compiler.enqueuer.codegen.nativeEnqueuer
+ .hasInstantiatedNativeClasses();
+
+ assert(!needsNativeSupport || nativeClasses.isNotEmpty);
+
return new Program(
fragments,
holders,
_buildLoadMap(),
_buildTypeToInterceptorMap(),
_task.metadataCollector,
- outputContainsNativeClasses: containsNativeClasses,
+ needsNativeSupport: needsNativeSupport,
outputContainsConstantList: _task.outputContainsConstantList,
hasIsolateSupport: _compiler.hasIsolateSupport);
}
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart ('k') | tests/lib/typed_data/byte_data_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698