Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1387)

Unified Diff: tests/lib/typed_data/native_interceptor_no_own_method_to_intercept_test.dart

Issue 957973006: dart2js: don't emit unneeded native info. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed comments. Changed to emit the interceptor and native info handling. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/lib/typed_data/native_interceptor_no_own_method_to_intercept_test.dart
diff --git a/runtime/tests/vm/dart/snapshot_version_test.dart b/tests/lib/typed_data/native_interceptor_no_own_method_to_intercept_test.dart
similarity index 50%
copy from runtime/tests/vm/dart/snapshot_version_test.dart
copy to tests/lib/typed_data/native_interceptor_no_own_method_to_intercept_test.dart
index 2dcde10186d899773cba16b7ec3e55ebb2101b76..751c6e1b50845aaf476b9ee036d1d6b5a4c525dd 100644
--- a/runtime/tests/vm/dart/snapshot_version_test.dart
+++ b/tests/lib/typed_data/native_interceptor_no_own_method_to_intercept_test.dart
@@ -2,13 +2,13 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-import "dart:io";
import "package:expect/expect.dart";
+import 'dart:typed_data';
floitsch 2015/03/02 14:26:01 dart: imports are before package: imports (iirc).
zarah 2015/03/02 15:40:35 Done, and changed for the other tests in this fold
main() {
- var result = Process.runSync(Platform.executable,
- [Platform.script.resolve('./bad_snapshot').toFilePath()]);
- print("=== stdout ===\n ${result.stdout}");
- print("=== stderr ===\n ${result.stderr}");
- Expect.equals(253, result.exitCode);
+ // Even though we are only calling toString() we should still have an
+ // interceptor for ByteData so that it doesn't end up as an unknown JS object.
+ // This test is just to make sure we don't crash.
+ new ByteData(1).toString();
floitsch 2015/03/02 14:26:01 You need to do something with the string as otherw
zarah 2015/03/02 15:40:35 Done.
}
+

Powered by Google App Engine
This is Rietveld 408576698