Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 957973003: Fix sky shell. (Closed)

Created:
5 years, 9 months ago by qsr
Modified:
5 years, 9 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix sky shell. This add the missing RequestNavigateHistory method on sky::Engine. It is currently not implemented. TBR=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/bd03be70adb5f8b1c40e2c5f105ac4cfc308e655

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M sky/shell/ui/engine.h View 1 chunk +1 line, -0 lines 0 comments Download
M sky/shell/ui/engine.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
qsr
Committed patchset #1 (id:1) manually as bd03be70adb5f8b1c40e2c5f105ac4cfc308e655 (presubmit successful).
5 years, 9 months ago (2015-02-26 09:46:28 UTC) #1
abarth-chromium
5 years, 9 months ago (2015-02-26 16:43:37 UTC) #2
Message was sent while issue was closed. 
LGTM Thanks!

Powered by Google App Engine
This is Rietveld 408576698