Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: net/proxy/proxy_resolver_perftest.cc

Issue 957933002: Lazily initialize the v8::Isolate used by ProxyResolverV8 (in the browser process). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/proxy/mojo_proxy_resolver_factory_impl.cc ('k') | net/proxy/proxy_resolver_v8.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/base_paths.h" 5 #include "base/base_paths.h"
6 #include "base/compiler_specific.h" 6 #include "base/compiler_specific.h"
7 #include "base/files/file_util.h" 7 #include "base/files/file_util.h"
8 #include "base/path_service.h" 8 #include "base/path_service.h"
9 #include "base/strings/string_util.h" 9 #include "base/strings/string_util.h"
10 #include "base/test/perf_time_logger.h" 10 #include "base/test/perf_time_logger.h"
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 CHECK(false); 208 CHECK(false);
209 return false; 209 return false;
210 } 210 }
211 211
212 void OnError(int line_number, const base::string16& message) override { 212 void OnError(int line_number, const base::string16& message) override {
213 CHECK(false); 213 CHECK(false);
214 } 214 }
215 }; 215 };
216 216
217 TEST(ProxyResolverPerfTest, ProxyResolverV8) { 217 TEST(ProxyResolverPerfTest, ProxyResolverV8) {
218 net::ProxyResolverV8::EnsureIsolateCreated();
219
220 MockJSBindings js_bindings; 218 MockJSBindings js_bindings;
221 net::ProxyResolverV8 resolver; 219 net::ProxyResolverV8 resolver;
222 resolver.set_js_bindings(&js_bindings); 220 resolver.set_js_bindings(&js_bindings);
223 PacPerfSuiteRunner runner(&resolver, "ProxyResolverV8"); 221 PacPerfSuiteRunner runner(&resolver, "ProxyResolverV8");
224 runner.RunAllTests(); 222 runner.RunAllTests();
225 } 223 }
OLDNEW
« no previous file with comments | « net/proxy/mojo_proxy_resolver_factory_impl.cc ('k') | net/proxy/proxy_resolver_v8.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698