Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 957823002: Remove ValidateSuperCall (Closed)

Created:
5 years, 10 months ago by arv (Not doing code reviews)
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove ValidateSuperCall We don't need this since this case is now a SyntaxError. BUG=None LOG=N R=dslomov@chromium.org Committed: https://crrev.com/5c19e4f1cb08c11e636315e6eea566794779b415 Cr-Commit-Position: refs/heads/master@{#26864}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -29 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/full-codegen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
arv (Not doing code reviews)
PTAL
5 years, 10 months ago (2015-02-25 18:54:29 UTC) #1
Dmitry Lomov (no reviews)
lgtm
5 years, 10 months ago (2015-02-25 21:41:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/957823002/1
5 years, 10 months ago (2015-02-25 21:43:41 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 21:46:42 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 21:47:12 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c19e4f1cb08c11e636315e6eea566794779b415
Cr-Commit-Position: refs/heads/master@{#26864}

Powered by Google App Engine
This is Rietveld 408576698