runtime/lib/string_patch.dart - Issue 957743002: Cleanup URI and use String.replaceRange.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/string_patch.dart

Issue 957743002: Cleanup URI and use String.replaceRange. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/lib/string_patch.dart

diff --git a/runtime/lib/string_patch.dart b/runtime/lib/string_patch.dart

index e3f5c68d923d8b28cad4dcb9425b7ed91fa37f0a..11db8fe066a8f4e74ede1e9d314ac6427f612edf 100644

--- a/runtime/lib/string_patch.dart

+++ b/runtime/lib/string_patch.dart

@@ -579,6 +579,7 @@ class _StringBase {

int length = this.length;

end = RangeError.checkValidRange(start, end, length);

bool replacementIsOneByte = replacement._isOneByte;

+ if (start == 0 && end == length) return replacement;

int replacementLength = replacement.length;

int totalLength = start + (length - end) + replacementLength;

if (replacementIsOneByte && this._isOneByte) {

« no previous file with comments | « no previous file | sdk/lib/core/uri.dart » ('j') | no next file with comments »