Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 957703004: cc: Fix animated filter render surface check (Closed)

Created:
5 years, 10 months ago by enne (OOO)
Modified:
5 years, 10 months ago
Reviewers:
Ian Vollick
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Fix animated filter render surface check The render surface calculation wasn't taking into account animated filters. These are animations which will eventually set a filter, but the filters on the layer are empty at render surface calculation time. This is just a missed case in render surface calculation, as it used to be handled naturally on the compositor thread after the filter got added. R=vollick@chromium.org BUG=461180 Committed: https://crrev.com/92f2f6d98e1934df969a240559b535919c3f1fd2 Cr-Commit-Position: refs/heads/master@{#318138}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -9 lines) Patch
M cc/trees/layer_tree_host_common.cc View 1 3 chunks +18 lines, -9 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
enne (OOO)
5 years, 10 months ago (2015-02-25 19:49:58 UTC) #1
Ian Vollick
lgtm! https://codereview.chromium.org/957703004/diff/1/cc/trees/layer_tree_host_common.cc File cc/trees/layer_tree_host_common.cc (right): https://codereview.chromium.org/957703004/diff/1/cc/trees/layer_tree_host_common.cc#newcode1220 cc/trees/layer_tree_host_common.cc:1220: DCHECK(!layer->HasCopyRequest()) << "layer: " << layer->id(); Ah nice ...
5 years, 10 months ago (2015-02-25 20:26:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/957703004/1
5 years, 10 months ago (2015-02-25 21:34:52 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja_ng/builds/14594)
5 years, 10 months ago (2015-02-25 21:45:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/957703004/20001
5 years, 10 months ago (2015-02-25 22:01:22 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-25 23:13:38 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 23:14:08 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/92f2f6d98e1934df969a240559b535919c3f1fd2
Cr-Commit-Position: refs/heads/master@{#318138}

Powered by Google App Engine
This is Rietveld 408576698