Rebase GDBJIT interface solely on JITCodeEvent

src/flag-definitions.h

Index: src/flag-definitions.h
diff --git a/src/flag-definitions.h b/src/flag-definitions.h
index f1b9b052e1d53fefd350536cc9bea0848923b4e9..e2d5d2be9a0dd62e595472065f04f01add797633 100644
--- a/src/flag-definitions.h
+++ b/src/flag-definitions.h
@@ -769,13 +769,28 @@ DEFINE_ARGS(js_arguments,
 //
 // GDB JIT integration flags.
 //
+#undef FLAG
+#ifdef ENABLE_GDB_JIT_INTERFACE
+#define FLAG FLAG_FULL
+#else
+#define FLAG FLAG_READONLY
+#endif
 
-DEFINE_BOOL(gdbjit, false, "enable GDBJIT interface (disables compacting GC)")
+DEFINE_BOOL(gdbjit, false, "enable GDBJIT interface")
 DEFINE_BOOL(gdbjit_full, false, "enable GDBJIT interface for all code objects")
 DEFINE_BOOL(gdbjit_dump, false, "dump elf objects with debug info to disk")
 DEFINE_STRING(gdbjit_dump_filter, "",
               "dump only objects containing this substring")
 
+#ifdef ENABLE_GDB_JIT_INTERFACE
+DEFINE_IMPLICATION(gdbjit_full, gdbjit)
+DEFINE_IMPLICATION(gdbjit_dump, gdbjit)
+#endif
+DEFINE_NEG_IMPLICATION(gdbjit, compact_code_space)
+
+#undef FLAG
+#define FLAG FLAG_FULL

[Michael Starzinger, 2015/02/25 10:16:45]

nit: Can we move the mark-compact.cc flags up a few lines (i.e. to around line
755)? Then redefining the FLAG to FLAG_FULL here wouldn't be necessary. WDYT?

[wingo, 2015/02/25 11:49:11]

Done.

+
 // mark-compact.cc
 DEFINE_BOOL(force_marking_deque_overflows, false,
             "force overflows of marking deque by reducing it's size "