chrome/browser/chromeos/chromeos_utils.h - Issue 957673003: Chrome OS Gaia: Set param 'chrometype' for MinuteMaid (chromebox, chromebase or chromebook)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/chromeos/chromeos_utils.h

Issue 957673003: Chrome OS Gaia: Set param 'chrometype' for MinuteMaid (chromebox, chromebase or chromebook) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/browser/chromeos/chromeos_utils.cc » ('j') | chrome/browser/chromeos/chromeos_utils.cc » ('J')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_CHROMEOS_CHROMEOS_UTILS_H_	5 #ifndef CHROME_BROWSER_CHROMEOS_CHROMEOS_UTILS_H_

6 #define CHROME_BROWSER_CHROMEOS_CHROMEOS_UTILS_H_	6 #define CHROME_BROWSER_CHROMEOS_CHROMEOS_UTILS_H_

7	7

8 #include "base/strings/string16.h"	8 #include "base/strings/string16.h"

9	9

10 namespace chromeos {	10 namespace chromeos {

11	11

12 // Returns the name of the Chrome device type (e.g. Chromebook, Chromebox).	12 // Returns the name of the Chrome device type (e.g. Chromebook, Chromebox).

13 base::string16 GetChromeDeviceType();	13 base::string16 GetChromeDeviceType();

14	14

15 // Returns the string resource ID for the name of the Chrome device type	15 // Returns the string resource ID for the name of the Chrome device type

16 // (e.g. IDS_CHROMEBOOK, IDS_CHROMEBOX).	16 // (e.g. IDS_CHROMEBOOK, IDS_CHROMEBOX).

17 int GetChromeDeviceTypeResourceId();	17 int GetChromeDeviceTypeResourceId();

18	18

	19 // Returns the name of the Chrome device type to pass to the MinuteMaid param

	20 // 'chrometype' (returns chromebox, chromebase or chromebook).

	21 std::string GetChromeDeviceTypeForMinuteMaid();
	Nikita (slow) 2015/02/25 09:28:43 Please rename to something like GetChromeDeviceTyp Please rename to something like GetChromeDeviceTypeString() Roman Sorokin (ftl) 2015/02/25 10:28:39 Done. Show quoted text On 2015/02/25 09:28:43, Nikita wrote: > Please rename to something like GetChromeDeviceTypeString() Done.
	22

19 } // namespace chromeos	23 } // namespace chromeos

20	24

21 #endif // CHROME_BROWSER_CHROMEOS_CHROMEOS_UTILS_H_	25 #endif // CHROME_BROWSER_CHROMEOS_CHROMEOS_UTILS_H_

OLD	NEW