Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 957663003: Files.app: Add new metadata properties that are needed for ImageEncoder. (Closed)

Created:
5 years, 10 months ago by hirono
Modified:
5 years, 10 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Add new metadata properties that are needed for ImageEncoder. BUG=410766 TEST=None Committed: https://crrev.com/442a5f8fd3e388820b17964eae2e817bb215067e Cr-Commit-Position: refs/heads/master@{#317999}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -7 lines) Patch
M ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js View 2 chunks +13 lines, -7 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/metadata_item.js View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
hirono
PTAL, thanks!
5 years, 10 months ago (2015-02-25 05:44:48 UTC) #2
yawano
lgtm with nit. https://codereview.chromium.org/957663003/diff/1/ui/file_manager/file_manager/foreground/js/metadata/metadata_item.js File ui/file_manager/file_manager/foreground/js/metadata/metadata_item.js (right): https://codereview.chromium.org/957663003/diff/1/ui/file_manager/file_manager/foreground/js/metadata/metadata_item.js#newcode144 ui/file_manager/file_manager/foreground/js/metadata/metadata_item.js:144: * TODO(hirono): Remove the metadata type. ...
5 years, 10 months ago (2015-02-25 06:04:52 UTC) #3
hirono
Thanks! https://codereview.chromium.org/957663003/diff/1/ui/file_manager/file_manager/foreground/js/metadata/metadata_item.js File ui/file_manager/file_manager/foreground/js/metadata/metadata_item.js (right): https://codereview.chromium.org/957663003/diff/1/ui/file_manager/file_manager/foreground/js/metadata/metadata_item.js#newcode144 ui/file_manager/file_manager/foreground/js/metadata/metadata_item.js:144: * TODO(hirono): Remove the metadata type. On 2015/02/25 ...
5 years, 10 months ago (2015-02-25 06:29:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/957663003/20001
5 years, 10 months ago (2015-02-25 06:29:49 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-25 07:20:16 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 07:20:43 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/442a5f8fd3e388820b17964eae2e817bb215067e
Cr-Commit-Position: refs/heads/master@{#317999}

Powered by Google App Engine
This is Rietveld 408576698