Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 957643002: Fix clipping of content outside the bounds of the window. (Closed)

Created:
5 years, 10 months ago by ojan
Modified:
5 years, 10 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix clipping of content outside the bounds of the window. https://codereview.chromium.org/899753003 incorrectly passed down the RenderView's clipping rect all the down through transforms instead of using the one from the LayerPaintingInfo, which is adjusted for transforms as you recurse down the tree. TBR=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/672a497379aa50b5b8462c3b292d5a3934f1fba4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -22 lines) Patch
M sky/engine/core/frame/FrameView.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 3 chunks +5 lines, -7 lines 0 comments Download
A + sky/tests/clipping/clipping-transforms.sky View 2 chunks +13 lines, -3 lines 0 comments Download
A + sky/tests/clipping/clipping-transforms-expected.sky View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 10 months ago (2015-02-25 04:40:12 UTC) #2
ojan
5 years, 10 months ago (2015-02-25 04:40:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
672a497379aa50b5b8462c3b292d5a3934f1fba4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698