Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 957603002: Strip cookies from getrealpan request. (Closed)

Created:
5 years, 10 months ago by Evan Stade
Modified:
5 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org, jstuppy, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Strip cookies from getrealpan request. Hopefully this addresses the scope errors the server was logging. BUG=none Committed: https://crrev.com/df12ac760d08c0bdba29567476d820ec0c395631 Cr-Commit-Position: refs/heads/master@{#318062}

Patch Set 1 #

Patch Set 2 : much simpler #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M components/autofill/core/browser/wallet/real_pan_wallet_client.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/autofill/core/browser/wallet/real_pan_wallet_client.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Evan Stade
+mmenke for review, since the changed code is all net:: related Is there any easier ...
5 years, 10 months ago (2015-02-25 01:25:53 UTC) #2
mmenke
On 2015/02/25 01:25:53, Evan Stade wrote: > +mmenke for review, since the changed code is ...
5 years, 10 months ago (2015-02-25 01:28:14 UTC) #3
Evan Stade
On 2015/02/25 01:28:14, mmenke wrote: > On 2015/02/25 01:25:53, Evan Stade wrote: > > +mmenke ...
5 years, 10 months ago (2015-02-25 01:36:04 UTC) #4
mmenke
On 2015/02/25 01:36:04, Evan Stade wrote: > On 2015/02/25 01:28:14, mmenke wrote: > > On ...
5 years, 10 months ago (2015-02-25 01:38:53 UTC) #5
Evan Stade
thanks mmenke. +brettw for review.
5 years, 10 months ago (2015-02-25 01:47:15 UTC) #7
brettw
lgtm
5 years, 10 months ago (2015-02-25 16:42:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/957603002/20001
5 years, 10 months ago (2015-02-25 16:43:54 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-25 16:58:06 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 16:58:37 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/df12ac760d08c0bdba29567476d820ec0c395631
Cr-Commit-Position: refs/heads/master@{#318062}

Powered by Google App Engine
This is Rietveld 408576698