Issue 957503002: Add tools/nanobench_flags.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 957503002: Add tools/nanobench_flags.py. (Closed)

Created:
5 years, 10 months ago by mtklein_C

Modified:
5 years, 10 months ago

Reviewers:
borenet, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Add tools/nanobench_flags.py. This should look suspiciously similar to tools/dm_flags.py. In fact, I tweaked tools/dm_flags.py a bit to make it even more suspiciously similar. I'll leave actually deduping this to future me. I noticed we have an opportunity to make our Valgrind run of nanobench faster, by not only making it not auto-calibrate (--loops 1) but also take only one measurement (--samples 1). Should be 5-10x faster than the default. BUG=skia: Committed: https://skia.googlesource.com/skia/+/f73e589c0d3d54371466dcaa0642925824df24d7

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+130 lines, -3 lines)			Patch
M	tools/dm_flags.py	View	3 chunks	+3 lines, -3 lines	0 comments	Download
A	tools/nanobench_flags.json	View	1 chunk	+36 lines, -0 lines	0 comments	Download
A	tools/nanobench_flags.py	View	1 chunk	+91 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/957503002/1

5 years, 10 months ago (2015-02-24 19:39:25 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-24 19:45:15 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f73e589c0d3d54371466dcaa0642925824df24d7

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages