Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Unified Diff: Source/platform/fonts/shaping/HarfBuzzShaper.h

Issue 957473003: Optimize complex text shaping (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase again Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/fonts/Character.h ('k') | Source/platform/fonts/shaping/HarfBuzzShaper.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/fonts/shaping/HarfBuzzShaper.h
diff --git a/Source/platform/fonts/shaping/HarfBuzzShaper.h b/Source/platform/fonts/shaping/HarfBuzzShaper.h
index 7a674d82c43db58abe78202aadc0812954ee6a51..55305e7cc13eb310cd612fe51786c4fe70d6a851 100644
--- a/Source/platform/fonts/shaping/HarfBuzzShaper.h
+++ b/Source/platform/fonts/shaping/HarfBuzzShaper.h
@@ -119,8 +119,12 @@ private:
void setFontFeatures();
+ template<typename CharType>
+ bool shapeInternal(GlyphBuffer*);
+ template<typename CharType>
bool createHarfBuzzRuns();
bool createHarfBuzzRunsForSingleCharacter();
+ template<typename CharType>
bool shapeHarfBuzzRuns();
bool fillGlyphBuffer(GlyphBuffer*);
float fillGlyphBufferFromHarfBuzzRun(GlyphBuffer*, HarfBuzzRun*, float initialAdvance);
@@ -129,9 +133,6 @@ private:
float adjustSpacing(HarfBuzzRun*, size_t glyphIndex, unsigned currentCharacterIndex, HarfBuzzRun* previousRun, float& offsetX, float& totalAdvance);
void addHarfBuzzRun(unsigned startCharacter, unsigned endCharacter, const SimpleFontData*, UScriptCode);
- OwnPtr<UChar[]> m_normalizedBuffer;
- unsigned m_normalizedBufferLength;
-
float m_wordSpacingAdjustment; // Delta adjustment (pixels) for each word break.
float m_letterSpacing; // Pixels to be added after each glyph.
unsigned m_expansionOpportunityCount;
« no previous file with comments | « Source/platform/fonts/Character.h ('k') | Source/platform/fonts/shaping/HarfBuzzShaper.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698