Remove SSE2 ColorRect32 code/files

src/opts/opts_check_x86.cpp

 /*
  * Copyright 2009 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkBitmapFilter_opts_SSE2.h"
 #include "SkBitmapProcState_opts_SSE2.h"
 #include "SkBitmapProcState_opts_SSSE3.h"
 #include "SkBitmapScaler.h"
 #include "SkBlitMask.h"
-#include "SkBlitRect_opts_SSE2.h"
 #include "SkBlitRow.h"
 #include "SkBlitRow_opts_SSE2.h"
 #include "SkBlitRow_opts_SSE4.h"
 #include "SkBlurImage_opts_SSE2.h"
 #include "SkBlurImage_opts_SSE4.h"
 #include "SkLazyPtr.h"
 #include "SkMorphology_opts.h"
 #include "SkMorphology_opts_SSE2.h"
 #include "SkRTConf.h"
 #include "SkUtils.h"
@@ skipping 231 matching lines @@
 }
 
 SkBlitRow::ColorProc SkBlitRow::PlatformColorProc() {
     if (supports_simd(SK_CPU_SSE_LEVEL_SSE2)) {
         return Color32_SSE2;
     } else {
         return NULL;
     }
 }
 
-SkBlitRow::ColorRectProc PlatformColorRectProcFactory(); // suppress warning

[mtklein, 2015/02/24 16:34:23]

I think you need to keep this.  Otherwise PlatformColorRectProcFactory isn't
declared here, and some of our compilers are helpful / anal about that.

[henrik.smiding, 2015/02/25 09:41:56]

Ok, I was hoping it was an old leftover, since the corresponding arm-file didn't
have it.

-
 SkBlitRow::ColorRectProc PlatformColorRectProcFactory() {
-/* Return NULL for now, since the optimized path in ColorRect32_SSE2 is disabled.
-    if (supports_simd(SK_CPU_SSE_LEVEL_SSE2)) {
-        return ColorRect32_SSE2;
-    } else {
-        return NULL;
-    }
-*/
     return NULL;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 
 SkBlitMask::ColorProc SkBlitMask::PlatformColorProcs(SkColorType dstCT,
                                                      SkMask::Format maskFormat,
                                                      SkColor color) {
     if (SkMask::kA8_Format != maskFormat) {
         return NULL;
@@ skipping 121 matching lines @@
     } else {
         return SkPlatformXfermodeFactory_impl(rec, mode);
     }
 }
 
 SkXfermodeProc SkPlatformXfermodeProcFactory(SkXfermode::Mode mode);
 
 SkXfermodeProc SkPlatformXfermodeProcFactory(SkXfermode::Mode mode) {
     return NULL;
 }