Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 957413002: MIPS: Also skip when the target is the global object. (Closed)

Created:
5 years, 10 months ago by balazs.kilvady
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Also skip when the target is the global object. Port cc918d30b9d586ce974b71232473f2ae3c5e7847 BUG= Committed: https://crrev.com/b24a0efa447235e11b9ff9d1eeaada06131b2e04 Cr-Commit-Position: refs/heads/master@{#26897}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/ic/mips/handler-compiler-mips.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
balazs.kilvady
5 years, 10 months ago (2015-02-26 18:24:43 UTC) #2
paul.l...
lgtm
5 years, 10 months ago (2015-02-26 18:31:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/957413002/1
5 years, 10 months ago (2015-02-26 18:32:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-26 19:30:47 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b24a0efa447235e11b9ff9d1eeaada06131b2e04 Cr-Commit-Position: refs/heads/master@{#26897}
5 years, 9 months ago (2015-02-26 19:31:03 UTC) #7
Michael Achenbach
5 years, 9 months ago (2015-02-26 21:00:57 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/963603002/ by machenbach@chromium.org.

The reason for reverting is: Need to revert the ported CL..

Powered by Google App Engine
This is Rietveld 408576698