Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 957393002: MIPS: Skip the mapcheck on the global object since the global proxy and cell are already checked (o… (Closed)

Created:
5 years, 10 months ago by balazs.kilvady
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Skip the mapcheck on the global object since the global proxy and cell are already checked (or the global object map for contextual global loads). Port 6af7ca6be4cd768b3326f0b8c32d4fbc3baa20c8 BUG= Committed: https://crrev.com/b9eb8f1fb898ac8c701a2557f6514fb9744f810f Cr-Commit-Position: refs/heads/master@{#26909}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M src/ic/mips/handler-compiler-mips.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
balazs.kilvady
5 years, 10 months ago (2015-02-26 17:45:18 UTC) #2
paul.l...
lgtm
5 years, 10 months ago (2015-02-26 18:30:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/957393002/1
5 years, 10 months ago (2015-02-26 18:32:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/315)
5 years, 10 months ago (2015-02-26 18:53:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/957393002/1
5 years, 9 months ago (2015-02-27 09:10:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-27 09:15:32 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 09:15:59 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9eb8f1fb898ac8c701a2557f6514fb9744f810f
Cr-Commit-Position: refs/heads/master@{#26909}

Powered by Google App Engine
This is Rietveld 408576698