Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 957373002: Revert "Revert of Fix memory leak caused by field type in descriptor array." (Closed)

Created:
5 years, 9 months ago by ulan
Modified:
5 years, 9 months ago
Reviewers:
marja
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "Revert of Fix memory leak caused by field type in descriptor array." This reverts commit b57be748b175695be2507cedf3423b59b9d6cd20 and disables the test/mjsunit/debug-clearbreakpointgroup.js because BreakLocationIterator::ClearBreakPoint is already broken for unrelated reasons (see v8:3924). BUG=v8:3877 LOG=N TEST=cctest/test-heap/Regress3877 Committed: https://crrev.com/bbf8c0f23d4995da2a9273e8aed818905f791167 Cr-Commit-Position: refs/heads/master@{#26893}

Patch Set 1 #

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -28 lines) Patch
M src/objects.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/objects.cc View 8 chunks +43 lines, -20 lines 0 comments Download
M src/objects-inl.h View 1 chunk +6 lines, -1 line 0 comments Download
M src/property.h View 1 chunk +7 lines, -3 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M test/cctest/test-migrations.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ulan
PTAL
5 years, 9 months ago (2015-02-26 15:57:42 UTC) #2
marja
lgtm
5 years, 9 months ago (2015-02-26 16:06:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/957373002/20001
5 years, 9 months ago (2015-02-26 16:06:54 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-02-26 18:38:29 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/bbf8c0f23d4995da2a9273e8aed818905f791167 Cr-Commit-Position: refs/heads/master@{#26893}
5 years, 9 months ago (2015-02-26 18:38:43 UTC) #7
Yang
5 years, 9 months ago (2015-03-19 07:05:12 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1023503003/ by yangguo@chromium.org.

The reason for reverting is: GC Stress breakage..

Powered by Google App Engine
This is Rietveld 408576698