miniz support in SkFlate / PDF

miniz support in SkFlate / PDF
   - Adds miniz.c v115_r4 (latest release) to third_party.
   - Merges SkDeflateWStream into SkFlate so including "miniz.c" links
     without duplicating symbols.

The only interesting code change I've made is to remove the line
     fImpl->fZStream.data_type = Z_BINARY;
from SkDeflateWStream::SkDeflateWStream().  miniz doesn't have Z_BINARY
defined, and as far as I can tell, both zlib and miniz ignore data_type.

We should be able to swap skflate.gyp's dependency between zlib.gyp:zlib and
zlib.gyp:miniz at will (except of course on Windows) if we're interested in
zlib itself.  I've left android framework on its own zlib.  I think this all
means we can stop defining SK_NO_FLATE on Windows.

I'll leave the possible cleanup of SK_NO_FLATE itself for another time.  Might
be we always want to keep this dependency optional.

CQ_EXTRA_TRYBOTS=client.skia:Test-Win8-ShuttleA-HD7770-x86-Debug-Trybot

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/e6cf9cb68511ff08156f834859db39232eb37be8

[mtklein_C, 2015-02-26 17:37:48]

mtklein@chromium.org changed reviewers:
+ halcanary@google.com, scroggo@google.com

[scroggo, 2015-02-26 17:56:53]

lgtm

https://codereview.chromium.org/957323003/diff/60001/src/core/SkFlate.h
File src/core/SkFlate.h (right):

https://codereview.chromium.org/957323003/diff/60001/src/core/SkFlate.h#newco...
src/core/SkFlate.h:18: #include "SkStream.h"
nit: Don't we typically place includes above class declarations? (Actually our
coding style guidelines don't specify that, but they do say "Forward
declarations and file includes should be in alphabetical order (but we aren't
very strict about it)," which could be taken to mean they should be
interspersed, but I haven't typically seen that.)

[scroggo, 2015-02-26 17:57:56]

I take it this replaces https://codereview.chromium.org/469813002/?

[mtklein, 2015-02-26 18:00:07]

On 2015/02/26 17:57:56, scroggo wrote:
> I take it this replaces https://codereview.chromium.org/469813002/

Guess so.

[mtklein, 2015-02-26 18:00:15]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2015-02-26 18:00:16]

https://codereview.chromium.org/957323003/diff/60001/src/core/SkFlate.h
File src/core/SkFlate.h (right):

https://codereview.chromium.org/957323003/diff/60001/src/core/SkFlate.h#newco...
src/core/SkFlate.h:18: #include "SkStream.h"
On 2015/02/26 17:56:53, scroggo wrote:
> nit: Don't we typically place includes above class declarations? (Actually our
> coding style guidelines don't specify that, but they do say "Forward
> declarations and file includes should be in alphabetical order (but we aren't
> very strict about it)," which could be taken to mean they should be
> interspersed, but I haven't typically seen that.)

I guess 'c' does come after '#'...

[hal.canary, 2015-02-26 19:26:25]

otherwise lgtm

https://codereview.chromium.org/957323003/diff/140001/src/core/SkFlate.h
File src/core/SkFlate.h (right):

https://codereview.chromium.org/957323003/diff/140001/src/core/SkFlate.h#newc...
src/core/SkFlate.h:49: class SkDeflateWStream : public SkWStream {
/**
 * Wrap a stream in this class to compress the information written to
 * this stream using the Deflate algorithm.  Uses Zlib's
 * Z_DEFAULT_COMPRESSION level.
 *
 * See http://en.wikipedia.org/wiki/DEFLATE
 */

[mtklein, 2015-02-26 19:32:51]

https://codereview.chromium.org/957323003/diff/140001/src/core/SkFlate.h
File src/core/SkFlate.h (right):

https://codereview.chromium.org/957323003/diff/140001/src/core/SkFlate.h#newc...
src/core/SkFlate.h:49: class SkDeflateWStream : public SkWStream {
On 2015/02/26 19:26:25, Hal Canary wrote:
> /**
>  * Wrap a stream in this class to compress the information written to
>  * this stream using the Deflate algorithm.  Uses Zlib's
>  * Z_DEFAULT_COMPRESSION level.
>  *
>  * See http://en.wikipedia.org/wiki/DEFLATE
>  */

Whoops, thank you. Done.

[mtklein, 2015-02-26 19:35:50]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-02-26 19:35:50]

The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com,
halcanary@google.com
Link to the patchset: https://codereview.chromium.org/957323003/#ps160001
(title: "class comment")

[commit-bot: I haz the power, 2015-02-26 19:36:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/957323003/160001

[commit-bot: I haz the power, 2015-02-26 21:25:11]

Committed patchset #9 (id:160001) as
https://skia.googlesource.com/skia/+/e6cf9cb68511ff08156f834859db39232eb37be8