Instrument the MutablePO2TS.

Instrument the MutablePO2TS.

BUG=461364
Committed: https://crrev.com/61f1c291a00919bf4a430d7c039f57db1f369235
Cr-Commit-Position: refs/heads/master@{#318257}

[Mike Lerman, 2015-02-26 14:05:20]

mlerman@chromium.org changed reviewers:
+ rogerta@chromium.org

[Mike Lerman, 2015-02-26 14:05:20]

Hi Roger,

Added some VLOGs to the MPO2TS. PTAL.

TY,
Mike

[Roger Tawa OOO till Jul 10th, 2015-02-26 15:23:48]

lgtm

https://codereview.chromium.org/957313002/diff/1/components/signin/core/brows...
File components/signin/core/browser/mutable_profile_oauth2_token_service.cc
(right):

https://codereview.chromium.org/957313002/diff/1/components/signin/core/brows...
components/signin/core/browser/mutable_profile_oauth2_token_service.cc:69: }
Add logs to ctor and dtor too.

https://codereview.chromium.org/957313002/diff/1/components/signin/core/brows...
components/signin/core/browser/mutable_profile_oauth2_token_service.cc:140:
ProfileOAuth2TokenService::Shutdown();
add log to shutdown

https://codereview.chromium.org/957313002/diff/1/components/signin/core/brows...
components/signin/core/browser/mutable_profile_oauth2_token_service.cc:191:
web_data_service_request_ = 0;
Add log here.  that way if this is seen but LoadAllCredentialsIntoMemory is not,
there was a persistence error.  maybe log the value or |result->GetType()| if
not null?

https://codereview.chromium.org/957313002/diff/1/components/signin/core/brows...
components/signin/core/browser/mutable_profile_oauth2_token_service.cc:281:
ValidateAccountId(account_id);
Log error here.

https://codereview.chromium.org/957313002/diff/1/components/signin/core/brows...
components/signin/core/browser/mutable_profile_oauth2_token_service.cc:337:
VLOG(1) << "MutablePO2TS::UpdateCredentials; Refresh Token was absent.";
Should add account_id to log for this one and line 327, 358, 374, 384

[Mike Lerman, 2015-02-26 16:11:53]

https://codereview.chromium.org/957313002/diff/1/components/signin/core/brows...
File components/signin/core/browser/mutable_profile_oauth2_token_service.cc
(right):

https://codereview.chromium.org/957313002/diff/1/components/signin/core/brows...
components/signin/core/browser/mutable_profile_oauth2_token_service.cc:69: }
On 2015/02/26 15:23:48, Roger Tawa wrote:
> Add logs to ctor and dtor too.

Done.

https://codereview.chromium.org/957313002/diff/1/components/signin/core/brows...
components/signin/core/browser/mutable_profile_oauth2_token_service.cc:140:
ProfileOAuth2TokenService::Shutdown();
On 2015/02/26 15:23:48, Roger Tawa wrote:
> add log to shutdown

Done.

https://codereview.chromium.org/957313002/diff/1/components/signin/core/brows...
components/signin/core/browser/mutable_profile_oauth2_token_service.cc:191:
web_data_service_request_ = 0;
On 2015/02/26 15:23:48, Roger Tawa wrote:
> Add log here.  that way if this is seen but LoadAllCredentialsIntoMemory is
not,
> there was a persistence error.  maybe log the value or |result->GetType()| if
> not null?

Done.

https://codereview.chromium.org/957313002/diff/1/components/signin/core/brows...
components/signin/core/browser/mutable_profile_oauth2_token_service.cc:281:
ValidateAccountId(account_id);
On 2015/02/26 15:23:48, Roger Tawa wrote:
> Log error here.

Done.

https://codereview.chromium.org/957313002/diff/1/components/signin/core/brows...
components/signin/core/browser/mutable_profile_oauth2_token_service.cc:337:
VLOG(1) << "MutablePO2TS::UpdateCredentials; Refresh Token was absent.";
On 2015/02/26 15:23:48, Roger Tawa wrote:
> Should add account_id to log for this one and line 327, 358, 374, 384

Done.

[Mike Lerman, 2015-02-26 16:11:59]

The CQ bit was checked by mlerman@chromium.org

[Mike Lerman, 2015-02-26 16:12:00]

The patchset sent to the CQ was uploaded after l-g-t-m from rogerta@chromium.org
Link to the patchset: https://codereview.chromium.org/957313002/#ps20001 (title:
"Include ctr, dtor and more. Include account_id.")

[commit-bot: I haz the power, 2015-02-26 16:13:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/957313002/20001

[commit-bot: I haz the power, 2015-02-26 18:04:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-26 18:05:43]

Patchset 2 (id:??) landed as
https://crrev.com/61f1c291a00919bf4a430d7c039f57db1f369235
Cr-Commit-Position: refs/heads/master@{#318257}