Issue 957303002: Make mojo_shell depend on NSS on Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 957303002: Make mojo_shell depend on NSS on Linux. (Closed)

Created:
5 years, 10 months ago by ppi

Modified:
5 years, 10 months ago

Reviewers:
qsr

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org, jamesr, Ryan Sleevi

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make mojo_shell depend on NSS on Linux. Due to dark magic in network service, it currently won't work on Linux unless the process that runs it has explicit linker dependency on NSS. http://crbug.com/462203 tracks a proper fix in Chromium. In the meantime, this is a temporary workaround until the issue is resolved or Chromium switches to BoringSSL on Linux, whichever happens first. Please see the bug for details. Note that we're adding the dependency regardless of use_openssl, because it's the flag that was set when building *the network service* that matters. BUG=456130 R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d10ab90c3c74c6e85cbe8817fc1b8b178ab7ad73

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	shell/BUILD.gn	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ppi

Thanks, Ben! Maybe https://codereview.chromium.org/962593002/ will change :( into :) at some point soon.

5 years, 10 months ago (2015-02-26 14:34:13 UTC) #4

ppi

5 years, 10 months ago (2015-02-26 14:35:14 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d10ab90c3c74c6e85cbe8817fc1b8b178ab7ad73 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages