Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 957253005: [Ozone] Update GYP and GN to include a DRM platform (Closed)

Created:
5 years, 9 months ago by dnicoara
Modified:
5 years, 9 months ago
Reviewers:
brettw, spang
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@split-host-gpu
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Ozone] Update GYP and GN to include a DRM platform This makes it possible to refer to the platform as DRI and DRM. We need this intermediate state so we can update the CrOS builds to use DRM rather than DRI. BUG=none TEST=Build ozone with DRI & DRM platform and without to verify build (GYP and GN) Committed: https://crrev.com/d89b572673f0fd352ae9d14e69b79e0430c87fbd Cr-Commit-Position: refs/heads/master@{#320788}

Patch Set 1 #

Patch Set 2 : fix media #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -10 lines) Patch
M build/common.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M build/filename_rules.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M build/linux/system.gyp View 1 chunk +1 line, -1 line 0 comments Download
M media/ozone/media_ozone_platform.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ui/ozone/BUILD.gn View 1 chunk +5 lines, -2 lines 1 comment Download
M ui/ozone/ozone.gni View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/ozone/ozone.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/drm.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/drm/ozone_platform_drm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/ozone_platform_drm.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
dnicoara
PTAL
5 years, 9 months ago (2015-03-04 16:45:35 UTC) #2
spang
lgtm
5 years, 9 months ago (2015-03-09 16:43:33 UTC) #3
dnicoara
+ brettw@ for build/ changes
5 years, 9 months ago (2015-03-09 16:56:22 UTC) #5
dnicoara
On 2015/03/09 16:56:22, dnicoara wrote: > + brettw@ for build/ changes ping
5 years, 9 months ago (2015-03-12 17:03:11 UTC) #6
brettw
Sorry for the delay, catching up after vacation. https://codereview.chromium.org/957253005/diff/20001/ui/ozone/BUILD.gn File ui/ozone/BUILD.gn (right): https://codereview.chromium.org/957253005/diff/20001/ui/ozone/BUILD.gn#newcode32 ui/ozone/BUILD.gn:32: if ...
5 years, 9 months ago (2015-03-13 23:14:48 UTC) #7
spang
On 2015/03/13 23:14:48, brettw wrote: > Sorry for the delay, catching up after vacation. > ...
5 years, 9 months ago (2015-03-14 00:04:15 UTC) #8
spang
On 2015/03/14 00:04:15, spang wrote: > On 2015/03/13 23:14:48, brettw wrote: > > Sorry for ...
5 years, 9 months ago (2015-03-14 00:06:53 UTC) #9
brettw
Okay, if this is going away soon it's OK. LGTM
5 years, 9 months ago (2015-03-16 17:57:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/957253005/20001
5 years, 9 months ago (2015-03-16 19:24:42 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-16 20:46:01 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 20:46:37 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d89b572673f0fd352ae9d14e69b79e0430c87fbd
Cr-Commit-Position: refs/heads/master@{#320788}

Powered by Google App Engine
This is Rietveld 408576698