Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 957253003: Fix chrome://history for supervised users on mobile (Closed)

Created:
5 years, 10 months ago by Marc Treib
Modified:
5 years, 10 months ago
CC:
chromium-reviews, Patrick Dubroy, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix chrome://history for supervised users on mobile - Don't use the groupByDomain version of the page (it's not adjusted for mobile yet) - Fix improper line breaks and formatting on blocked entries - Show the "blocked visit" icon - Hide the delete buttons BUG=452859 Committed: https://crrev.com/53bf63189adff10a7731b82db59e77d7ffa42234 Cr-Commit-Position: refs/heads/master@{#318234}

Patch Set 1 #

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -23 lines) Patch
M chrome/browser/resources/history/history.css View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/history/history.js View 2 chunks +18 lines, -17 lines 0 comments Download
M chrome/browser/resources/history/history_mobile.css View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/history_ui.cc View 1 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Marc Treib
PTAL!
5 years, 10 months ago (2015-02-26 10:02:36 UTC) #2
Marc Treib
On 2015/02/26 10:02:36, Marc Treib wrote: > PTAL! Before/after screenshots are linked on the bug.
5 years, 10 months ago (2015-02-26 10:03:14 UTC) #3
Pam (message me for reviews)
lgtm
5 years, 10 months ago (2015-02-26 14:05:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/957253003/20001
5 years, 10 months ago (2015-02-26 14:20:29 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-26 15:31:48 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 15:32:42 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/53bf63189adff10a7731b82db59e77d7ffa42234
Cr-Commit-Position: refs/heads/master@{#318234}

Powered by Google App Engine
This is Rietveld 408576698