Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: base/process/process_posix.cc

Issue 957183002: Remove base::WaitForExitCode* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/process/process_posix.cc
diff --git a/base/process/process_posix.cc b/base/process/process_posix.cc
index bc2f3f8bfa628febe97f73a21120525306b6d515..cc7557589f391f4b559f57bb015919bb3843cea9 100644
--- a/base/process/process_posix.cc
+++ b/base/process/process_posix.cc
@@ -102,15 +102,13 @@ void Process::Terminate(int result_code) {
}
bool Process::WaitForExit(int* exit_code) {
- // TODO(rvargas) crbug.com/417532: Remove this constant.
- const int kNoTimeout = -1;
- return WaitForExitWithTimeout(TimeDelta::FromMilliseconds(kNoTimeout),
- exit_code);
+ return
+ WaitForExitWithTimeout(TimeDelta::FromMilliseconds(internal::kNoTimeout),
+ exit_code);
}
bool Process::WaitForExitWithTimeout(TimeDelta timeout, int* exit_code) {
- // TODO(rvargas) crbug.com/417532: Move the implementation here.
- return base::WaitForExitCodeWithTimeout(Handle(), exit_code, timeout);
+ return internal::WaitForExitCodeWithTimeout(Handle(), exit_code, timeout);
}
#if !defined(OS_LINUX)

Powered by Google App Engine
This is Rietveld 408576698