Inline signin UI should auto focus gaia frame

Inline signin UI should auto focus gaia frame

BUG=324353
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238222

[guohui, 2013-11-28 21:24:11]

Hey,

could you please take a look at the CL?

Thanks,

Hui

[Roger Tawa OOO till Jul 10th, 2013-11-28 21:29:00]

lgtm

[guohui, 2013-11-29 18:17:37]

On 2013/11/28 21:29:00, Roger Tawa wrote:
> lgtm

ping nikita for owner review?

[xiyuan, 2013-12-02 19:26:37]

https://codereview.chromium.org/95713002/diff/1/chrome/browser/resources/gaia...
File chrome/browser/resources/gaia_auth/main.js (right):

https://codereview.chromium.org/95713002/diff/1/chrome/browser/resources/gaia...
chrome/browser/resources/gaia_auth/main.js:191: $('gaia-frame').focus();
This might interfere with chromeos login screen's focus handling. In cros login
screen, gaia could be loaded in the background with the account pods visible and
we don't want to put focus to gaia in this case. We need to differentiate and
only do this for inline signin flow.

[guohui, 2013-12-02 19:32:00]

https://codereview.chromium.org/95713002/diff/1/chrome/browser/resources/gaia...
File chrome/browser/resources/gaia_auth/main.js (right):

https://codereview.chromium.org/95713002/diff/1/chrome/browser/resources/gaia...
chrome/browser/resources/gaia_auth/main.js:191: $('gaia-frame').focus();
On 2013/12/02 19:26:37, xiyuan wrote:
> This might interfere with chromeos login screen's focus handling. In cros
login
> screen, gaia could be loaded in the background with the account pods visible
and
> we don't want to put focus to gaia in this case. We need to differentiate and
> only do this for inline signin flow.

Done.

[xiyuan, 2013-12-02 20:52:37]

LGTM

Thanks.

[commit-bot: I haz the power, 2013-12-02 20:56:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/guohui@chromium.org/95713002/20001

[commit-bot: I haz the power, 2013-12-02 23:13:00]

Change committed as 238222