Typecheck map and list literals

lib/src/options.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Set of flags and options passed to the compiler
 library ddc.src.options;
 
 import 'dart:io';
 
 import 'package:args/args.dart';
@@ skipping 45 matching lines @@
   ResolverOptions({this.useMultiPackage: false, this.packageRoot: 'packages/',
       this.packagePaths: const [], this.inferFromOverrides: true,
       this.inferStaticsFromIdentifiers: false,
       this.inferInNonStableOrder: false,
       this.onlyInferConstsAndFinalFields: false});
 }
 
 // TODO(vsm): Merge RulesOptions and TypeOptions
 /// Options used by ddc's RestrictedRules.
 class RulesOptions extends TypeOptions {
+  /// Whether to allow casts in constant contexts.
+  final bool allowConstCasts;
+
   /// Whether to use covariant generics
   final bool covariantGenerics;
 
   /// Whether to inject casts between Dart assignable types.
   final bool relaxedCasts;
 
   /// Whether to use static types for code generation.
   final bool ignoreTypes;
 
-  RulesOptions({this.covariantGenerics: true, this.relaxedCasts: true,
-      this.ignoreTypes: false});
+  RulesOptions({this.allowConstCasts: true, this.covariantGenerics: true,
+      this.relaxedCasts: true, this.ignoreTypes: false});
 }
 
 /// General options used by the dev compiler.
 class CompilerOptions implements RulesOptions, ResolverOptions {
   /// Whether to check the sdk libraries.
   final bool checkSdk;
 
   /// Whether to dump summary information on the console.
   final bool dumpInfo;
 
@@ skipping 33 matching lines @@
   /// Path to the dart-sdk. Null if `useMockSdk` is true or if the path couldn't
   /// be determined
   final String dartSdkPath;
 
   /// Minimum log-level reported on the command-line.
   final Level logLevel;
 
   /// File where to start compilation from.
   final String entryPointFile;
 
+  /// Whether to allow casts in constant contexts.
+  @override
+  final bool allowConstCasts;
+
   /// Whether to use covariant generics
   @override
   final bool covariantGenerics;
 
   /// Whether to inject casts between Dart assignable types.
   @override
   final bool relaxedCasts;
 
   /// Whether to resolve 'package:' uris using the multi-package resolver.
   @override
@@ skipping 26 matching lines @@
   final bool onlyInferConstsAndFinalFields;
 
   /// List of non-nullable types.
   @override
   final List<String> nonnullableTypes;
 
   /// Whether to use static types for code generation.
   @override
   final bool ignoreTypes;
 
-  CompilerOptions({this.checkSdk: false, this.dumpInfo: false,
-      this.dumpInfoFile, this.dumpSrcDir, this.forceCompile: false,
-      this.formatOutput: false, this.cheapTestFormat: false,
-      this.ignoreTypes: false, this.outputDir, this.outputDart: false,
-      this.useColors: true, this.covariantGenerics: true,
-      this.relaxedCasts: true, this.useMultiPackage: false,
-      this.packageRoot: 'packages/', this.packagePaths: const [],
-      this.inferFromOverrides: true, this.inferStaticsFromIdentifiers: false,
+  CompilerOptions({this.allowConstCasts: true, this.checkSdk: false,
+      this.dumpInfo: false, this.dumpInfoFile, this.dumpSrcDir,
+      this.forceCompile: false, this.formatOutput: false,
+      this.cheapTestFormat: false, this.ignoreTypes: false, this.outputDir,
+      this.outputDart: false, this.useColors: true,
+      this.covariantGenerics: true, this.relaxedCasts: true,
+      this.useMultiPackage: false, this.packageRoot: 'packages/',
+      this.packagePaths: const [], this.inferFromOverrides: true,
+      this.inferStaticsFromIdentifiers: false,
       this.inferInNonStableOrder: false,
       this.onlyInferConstsAndFinalFields: false,
       this.nonnullableTypes: TypeOptions.NONNULLABLE_TYPES, this.help: false,
       this.useMockSdk: false, this.dartSdkPath, this.logLevel: Level.SEVERE,
       this.entryPointFile: null});
 }
 
 /// Parses options from the command-line
 CompilerOptions parseOptions(List<String> argv) {
   ArgResults args = argParser.parse(argv);
   var levelName = args['log'].toUpperCase();
   var useColors = stdioType(stdout) == StdioType.TERMINAL;
   var sdkPath = args['dart-sdk'];
   if (sdkPath == null && !args['mock-sdk']) {
     sdkPath = getSdkDir(argv).path;
   }
   return new CompilerOptions(
+      allowConstCasts: args['allow-const-casts'],
       checkSdk: args['sdk-check'],
       dumpInfo: args['dump-info'],
       dumpInfoFile: args['dump-info-file'],
       dumpSrcDir: args['dump-src-to'],
       forceCompile: args['force-compile'],
       formatOutput: args['dart-gen-fmt'],
       ignoreTypes: args['ignore-types'],
       outputDart: args['dart-gen'],
       outputDir: args['out'],
       covariantGenerics: args['covariant-generics'],
@@ skipping 11 matching lines @@
       help: args['help'],
       useMockSdk: args['mock-sdk'],
       dartSdkPath: sdkPath,
       logLevel: Level.LEVELS.firstWhere((Level l) => l.name == levelName,
           orElse: () => Level.SEVERE),
       entryPointFile: args.rest.length == 0 ? null : args.rest.first);
 }
 
 final ArgParser argParser = new ArgParser()
   // resolver/checker options
-  ..addFlag(
-      'sdk-check', abbr: 's', help: 'Typecheck sdk libs', defaultsTo: false)
+  ..addFlag('allow-const-casts',
+      help: 'Allow casts in const contexts', defaultsTo: true)
+  ..addFlag('sdk-check',
+      abbr: 's', help: 'Typecheck sdk libs', defaultsTo: false)
   ..addFlag('mock-sdk',
       abbr: 'm', help: 'Use a mock Dart SDK', defaultsTo: false)
   ..addFlag('covariant-generics',
       help: 'Use covariant generics', defaultsTo: true)
   ..addFlag('ignore-types',
       help: 'Ignore types during codegen', defaultsTo: false)
   ..addFlag('relaxed-casts',
       help: 'Cast between Dart assignable types', defaultsTo: true)
   ..addOption('nonnullable',
       abbr: 'n',
@@ skipping 34 matching lines @@
   ..addFlag('help', abbr: 'h', help: 'Display this message')
   ..addFlag('force-compile',
       help: 'Compile code with static errors', defaultsTo: false)
   ..addOption('log', abbr: 'l', help: 'Logging level', defaultsTo: 'severe')
   ..addFlag('dump-info',
       abbr: 'i', help: 'Dump summary information', defaultsTo: false)
   ..addOption('dump-info-file',
       abbr: 'f',
       help: 'Dump info json file (requires dump-info)',
       defaultsTo: null);