Issue 95693002: <webview>: Expose transparency API

Issue 95693002: <webview>: Expose transparency API (Closed)

Created:
7 years ago by Fady Samuel

Modified:
7 years ago

Reviewers:
alexst (slow to review)

CC:
chromium-reviews, joi+watch-content_chromium.org, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

<webview>: Expose transparency API BUG=157628 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238428

Patch Set 2 : Removed unnecessary line #

Total comments: 1

Patch Set 3 : Added comment #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -28 lines)			Patch
M	chrome/renderer/resources/extensions/web_view.js	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	content/common/browser_plugin/browser_plugin_constants.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/common/browser_plugin/browser_plugin_constants.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/browser_plugin/browser_plugin.h	View	1 2	3 chunks	+5 lines, -7 lines	0 comments	Download
M	content/renderer/browser_plugin/browser_plugin.cc	View	1	6 chunks	+21 lines, -20 lines	0 comments	Download
M	content/renderer/browser_plugin/browser_plugin_bindings.cc	View		2 chunks	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Fady Samuel

Is there a way to tell the compositor we need an entirely new frame (not ...

7 years ago (2013-11-28 20:43:51 UTC) #1

alexst (slow to review)

https://codereview.chromium.org/95693002/diff/1/content/renderer/browser_plugin/browser_plugin.cc File content/renderer/browser_plugin/browser_plugin.cc (right): https://codereview.chromium.org/95693002/diff/1/content/renderer/browser_plugin/browser_plugin.cc#newcode271 content/renderer/browser_plugin/browser_plugin.cc:271: paint_ack_received_ = false; Why did you need to change ...

7 years ago (2013-11-28 21:44:56 UTC) #2

Fady Samuel

PTAL https://codereview.chromium.org/95693002/diff/1/content/renderer/browser_plugin/browser_plugin.cc File content/renderer/browser_plugin/browser_plugin.cc (right): https://codereview.chromium.org/95693002/diff/1/content/renderer/browser_plugin/browser_plugin.cc#newcode271 content/renderer/browser_plugin/browser_plugin.cc:271: paint_ack_received_ = false; On 2013/11/28 21:44:57, alexst wrote: ...

7 years ago (2013-12-02 18:30:04 UTC) #3

alexst (slow to review)

lgtm with nit. https://codereview.chromium.org/95693002/diff/20001/content/renderer/browser_plugin/browser_plugin.h File content/renderer/browser_plugin/browser_plugin.h (right): https://codereview.chromium.org/95693002/diff/20001/content/renderer/browser_plugin/browser_plugin.h#newcode65 content/renderer/browser_plugin/browser_plugin.h:65: // Parse the allowtransparency attribute. Describe ...

7 years ago (2013-12-02 19:03:24 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/95693002/40001

7 years ago (2013-12-03 16:01:41 UTC) #6

Message was sent while issue was closed.

Change committed as 238428

Expand Messages | Collapse Messages