Issue 956883002: Add dummy implementation to MockVideoSource.

Issue 956883002: Add dummy implementation to MockVideoSource. (Closed)

Created:
5 years, 10 months ago by perkj_chrome

Modified:
5 years, 10 months ago

Reviewers:
magjed_chromium

CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add dummy implementation to MockVideoSource. Adding MockVideoSource::Stop and ::Restart so that the interface can be made pure virtual. Committed: https://crrev.com/c7de43c189ea30fa76e3d721f01f657892bcb31c Cr-Commit-Position: refs/heads/master@{#318028}

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	content/renderer/media/webrtc/mock_peer_connection_dependency_factory.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/956883002/20001

5 years, 10 months ago (2015-02-25 11:27:39 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-25 12:17:42 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/c7de43c189ea30fa76e3d721f01f657892bcb31c
Cr-Commit-Position: refs/heads/master@{#318028}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages