Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 956873002: Revert of [DevTools] Check request_id in DevToolsUIBindings::IndexPath (Closed)

Created:
5 years, 10 months ago by phoglund_chromium
Modified:
5 years, 10 months ago
Reviewers:
vkuzkokov, dgozman
CC:
chromium-reviews, aandrey+blink_chromium.org, vsevik, yurys, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [DevTools] Check request_id in DevToolsUIBindings::IndexPath (patchset #1 id:1 of https://codereview.chromium.org/951953002/) Reason for revert: Speculative revert: http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/4683/steps/browser_tests%20on%20Mac-10.6/logs/DevToolsSanityTest.TestReattachAfterCrash became very flaky on Mac OS X 10.6 about when this patch was introduced. This is the only devtools change near to the start of the flakiness. The errors are: DevToolsSanityTest.TestReattachAfterCrash (run #1): [ RUN ] DevToolsSanityTest.TestReattachAfterCrash [32422:28675:0224/105826:WARNING:data_reduction_proxy_config.cc(211)] SPDY proxy OFF at startup HTTP server started on http://127.0.0.1:64960... sending server_data: {"host": "127.0.0.1", "port": 64960} (36 bytes) [32427:9479:0224/105828:WARNING:channel.cc(547)] Failed to send message to ack remove remote endpoint (local ID 1, remote ID 1) [32427:9479:0224/105828:WARNING:channel.cc(547)] Failed to send message to ack remove remote endpoint (local ID 2147483648, remote ID 2 Original issue's description: > [DevTools] Check request_id in DevToolsUIBindings::IndexPath > > If request_id is reused before the previous job with the same id is finished the old job won't be stopped in ~DevToolsUIBindings. > > BUG= > > Committed: https://crrev.com/88ac3ce8fa6463e5f04d4b3e7e2327e2ec1b3a19 > Cr-Commit-Position: refs/heads/master@{#317799} TBR=dgozman@chromium.org,vkuzkokov@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/012bebf20cabd5a81179a185b87bd75f632edb66 Cr-Commit-Position: refs/heads/master@{#318019}

Patch Set 1 #

Patch Set 2 : Resolved conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/browser/devtools/devtools_ui_bindings.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
phoglund_chromium
Created Revert of [DevTools] Check request_id in DevToolsUIBindings::IndexPath
5 years, 10 months ago (2015-02-25 10:19:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/956873002/1
5 years, 10 months ago (2015-02-25 10:20:40 UTC) #2
commit-bot: I haz the power
Failed to apply patch for chrome/browser/devtools/devtools_ui_bindings.cc: While running git apply --index -3 -p1; error: patch ...
5 years, 10 months ago (2015-02-25 10:21:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/956873002/40001
5 years, 10 months ago (2015-02-25 10:43:42 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 10 months ago (2015-02-25 10:44:20 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/012bebf20cabd5a81179a185b87bd75f632edb66 Cr-Commit-Position: refs/heads/master@{#318019}
5 years, 10 months ago (2015-02-25 10:45:15 UTC) #9
vkuzkokov
On 2015/02/25 10:44:20, I haz the power (commit-bot) wrote: > Committed patchset #2 (id:40001) FYI, ...
5 years, 10 months ago (2015-02-25 10:46:06 UTC) #10
phoglund_chromium
5 years, 10 months ago (2015-02-25 11:09:54 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/957623003/ by phoglund@chromium.org.

The reason for reverting is: Turns out the revert was incorrect (the error even
started happening a couple builds before this patch)..

Powered by Google App Engine
This is Rietveld 408576698