OLD | NEW |
1 Landing Skia changes which require associated Chrome changes | 1 Chrome changes |
2 ============================================================ | 2 ============== |
3 | 3 |
4 If your change modifies the Skia API, you may also need to land a change in Chro
mium. | 4 If your change modifies the Skia API, you may also need to land a change in Chro
mium. |
5 | 5 |
6 The strategy you use to synchronize changes in the Skia and Chromium | 6 The strategy you use to synchronize changes in the Skia and Chromium |
7 repositories may differ based on the nature of the change, but in general, we | 7 repositories may differ based on the nature of the change, but in general, we |
8 recommend using build flag suppressions \(defines\)\. | 8 recommend using build flag suppressions \(defines\)\. |
9 We also prefer making the old code path opt-in where possible. | 9 We also prefer making the old code path opt-in where possible. |
10 | 10 |
11 Method 1 \(preferred\) \- Make the old code path opt\-in for Chromium | 11 Method 1 \(preferred\) \- Make the old code path opt\-in for Chromium |
12 | 12 |
13 * Add new code to Skia, leaving the old code in place. | 13 * Add new code to Skia, leaving the old code in place. |
14 * Deprecate the old code path so that it must be enabled with a flag such as | 14 * Deprecate the old code path so that it must be enabled with a flag such as |
15 'SK_SUPPORT_LEGACY_XXX'. | 15 'SK_SUPPORT_LEGACY_XXX'. |
16 * Synchronize the above changes in Skia with a Chromium commit to | 16 * Synchronize the above changes in Skia with a Chromium commit to |
17 'skia/skia_common.gypi' or 'skia/config/SkUserConfig.h' to enable the | 17 'skia/skia_common.gypi' or 'skia/config/SkUserConfig.h' to enable the |
18 deprecated Skia API. | 18 deprecated Skia API. |
19 * Note that the code suppression cannot exist in both the header file and | 19 * Note that the code suppression cannot exist in both the header file and |
20 the gyp file, it should only reside in one location. | 20 the gyp file, it should only reside in one location. |
21 * Test the new or updated Skia API within Chromium. | 21 * Test the new or updated Skia API within Chromium. |
22 * Remove the flag and code when the legacy code path is no longer in use. | 22 * Remove the flag and code when the legacy code path is no longer in use. |
23 | 23 |
24 Method 2 \- Make the new code path opt\-in for Chromium | 24 Method 2 \- Make the new code path opt\-in for Chromium |
25 | 25 |
26 * Add new code to Skia, suppressed by a flag. | 26 * Add new code to Skia, suppressed by a flag. |
27 * Leave the old code path in place. | 27 * Leave the old code path in place. |
28 * Set the flag in Chromium's 'skia/skia_common.gypi' or | 28 * Set the flag in Chromium's 'skia/skia_common.gypi' or |
29 'skia/config/SkUserConfig.h' to enable the new or updated Skia API. | 29 'skia/config/SkUserConfig.h' to enable the new or updated Skia API. |
30 * Test the new or updated Skia API within Chromium. | 30 * Test the new or updated Skia API within Chromium. |
31 * Remove the code suppression \(and code\) when the legacy API is no longer | 31 * Remove the code suppression \(and code\) when the legacy API is no longer |
32 in use. | 32 in use. |
33 | 33 |
34 If your changes will affect Blink layout tests, see detailed instructions about | 34 If your changes will affect Blink layout tests, see detailed instructions about |
35 how to synchronize the changes between Skia, Blink, and Chromium [here](./blink)
. | 35 how to synchronize the changes between Skia, Blink, and Chromium [here](./blink)
. |
OLD | NEW |