Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 956853002: Fix JS errors of FileTransferController. (Closed)

Created:
5 years, 10 months ago by hirono
Modified:
5 years, 10 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix JS errors of FileTransferController. Previously Files.app does not preapre container object of AsyncData if the selection includes directory. Thus it raises exceptions when it tries to store data to the container object. The CL let Files.app prepares the container object always. BUG=461726 TEST=None Committed: https://crrev.com/42e39712923bd4ae01458124e9183492adb099a6 Cr-Commit-Position: refs/heads/master@{#318187}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/file_manager/file_manager/foreground/js/file_transfer_controller.js View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
hirono
PTAL, thanks!
5 years, 10 months ago (2015-02-26 02:16:40 UTC) #2
mtomasz
Thanks! lgtm!
5 years, 10 months ago (2015-02-26 04:12:31 UTC) #3
hirono
On 2015/02/26 04:12:31, mtomasz wrote: > Thanks! lgtm! Thanks!
5 years, 10 months ago (2015-02-26 04:37:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/956853002/1
5 years, 10 months ago (2015-02-26 04:38:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-26 04:47:58 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 04:48:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42e39712923bd4ae01458124e9183492adb099a6
Cr-Commit-Position: refs/heads/master@{#318187}

Powered by Google App Engine
This is Rietveld 408576698