Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 956803003: Update test result after crrev.com/914233002 (Closed)

Created:
5 years, 10 months ago by k.czech
Modified:
5 years, 10 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, je_julie(Not used), plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update test result after crrev.com/914233002 Blink's CL changes approach of colspan's calculating. Calculation is based on effective columns's conversion. Malformed colspan such as <table><tr><td colspan="10"></td><th></th></tr></table> now is calculated as {0, 1} not {0, 10} Update also a test case so that we could check valid colspans. BUG=457687 Committed: https://crrev.com/dc6a105a98c482ac0b46024d6d9b4784e0b368fd Cr-Commit-Position: refs/heads/master@{#318267}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -5 lines) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/test/data/accessibility/html/table-spans.html View 1 chunk +10 lines, -0 lines 0 comments Download
M content/test/data/accessibility/html/table-spans-expected-mac.txt View 1 chunk +16 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
k.czech
Test is skipped on win and android.
5 years, 10 months ago (2015-02-25 23:03:41 UTC) #2
dmazzoni
lgtm
5 years, 10 months ago (2015-02-26 17:41:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/956803003/1
5 years, 10 months ago (2015-02-26 17:42:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-26 18:36:10 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 18:38:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc6a105a98c482ac0b46024d6d9b4784e0b368fd
Cr-Commit-Position: refs/heads/master@{#318267}

Powered by Google App Engine
This is Rietveld 408576698