Implement the close() API for Message ports

android_webview/java/src/org/chromium/android_webview/PostMessageSender.java

Index: android_webview/java/src/org/chromium/android_webview/PostMessageSender.java
diff --git a/android_webview/java/src/org/chromium/android_webview/PostMessageSender.java b/android_webview/java/src/org/chromium/android_webview/PostMessageSender.java
index 79518385641a319c246a8959f8931f0234d1c85d..78830999e709ab21737ed6d0c5040464b6150dd8 100644
--- a/android_webview/java/src/org/chromium/android_webview/PostMessageSender.java
+++ b/android_webview/java/src/org/chromium/android_webview/PostMessageSender.java
@@ -22,6 +22,16 @@ public class PostMessageSender implements AwMessagePortService.MessageChannelObs
          */
         void postMessageToWeb(String frameName, String message, String targetOrigin,
                 int[] sentPortIds);
+
+        /*
+         * Whether the post message sender is ready to post messages.
+         */
+        boolean isPostMessageSenderReady();
+
+        /*
+         * Informs that all messages are posted and message queue is empty.
+         */
+        void onPostMessageQueueEmpty();
     };
 
     // A struct to store Message parameters that are sent from App to Web.
@@ -54,6 +64,10 @@ public class PostMessageSender implements AwMessagePortService.MessageChannelObs
         mService = service;
     }
 
+    public boolean isMessageQueueEmpty() {
+        return mMessageQueue.size() > 0;

[hush (inactive), 2015/02/25 19:44:27]

shouldn't this be == 0? I will be surprised if the tests pass with this...

[sgurun-gerrit only, 2015/02/25 21:38:53]

Done.

+    }
+
     // Return true if any sent port is pending.
     private boolean anySentPortIsPending(MessagePort[] sentPorts) {
         if (sentPorts != null) {
@@ -66,11 +80,6 @@ public class PostMessageSender implements AwMessagePortService.MessageChannelObs
         return false;
     }
 
-    // By default the sender is always ready.
-    protected boolean senderIsReady() {
-        return true;
-    }
-
     // A message to a frame is queued if:
     // 1. Sender is not ready to post. When posting messages to frames, sender is always
     // ready. However, when posting messages using message channels, sender may be in
@@ -80,7 +89,7 @@ public class PostMessageSender implements AwMessagePortService.MessageChannelObs
     private boolean shouldQueueMessage(MessagePort[] sentPorts) {
         // if messages to frames are already in queue mode, simply queue it, no need to
         // check ports.
-        if (mMessageQueue.size() > 0 || !senderIsReady()) {
+        if (mMessageQueue.size() > 0 || !mDelegate.isPostMessageSenderReady()) {

[hush (inactive), 2015/02/25 19:44:27]

use isMessageQueueEmpty() here since you have created such a method

[sgurun-gerrit only, 2015/02/25 21:38:53]

I think I can read this a lot faster :) the method is for public access

             return true;
         }
         if (anySentPortIsPending(sentPorts)) {
@@ -131,7 +140,7 @@ public class PostMessageSender implements AwMessagePortService.MessageChannelObs
     public void onMessageChannelCreated() {
         PostMessageParams msg;
 
-        if (!senderIsReady()) {
+        if (!mDelegate.isPostMessageSenderReady()) {
             return;
         }
 
@@ -143,5 +152,6 @@ public class PostMessageSender implements AwMessagePortService.MessageChannelObs
             mMessageQueue.remove();
             postMessageToWeb(msg.frameName, msg.message, msg.targetOrigin, msg.sentPorts);
         }
+        mDelegate.onPostMessageQueueEmpty();
     }
 }