Implement the close() API for Message ports

android_webview/common/aw_message_port_messages.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included file, no traditional include guard.
 #include <vector>
 
 #include "base/basictypes.h"
 #include "ipc/ipc_message_macros.h"
 
@@ skipping 40 matching lines @@
 // Tells the renderer to convert the message from a String16
 // format to a WebSerializedScriptValue. This IPC is used for messages that
 // are outgoing from Webview to JS.
 // TODO(sgurun) when we start supporting other types, use a ListValue instead
 // of string16
 IPC_MESSAGE_ROUTED3(AwMessagePortMsg_AppToWebMessage,
                     int /* recipient message port id */,
                     base::string16 /* message */,
                     std::vector<int> /* sent message port_ids */)
 
+// Used to defer message port closing until after all in-flight messages
+// are flushed from renderer to browser. Renderer piggy-backs the message
+// to browser.
+IPC_MESSAGE_ROUTED1(AwMessagePortMsg_ClosePort,
+                    int /* message port id */)
+
 //-----------------------------------------------------------------------------
 // These are messages sent from the renderer to the browser process.
 
 // Response to AwMessagePortMessage_WebToAppMessage
 IPC_MESSAGE_ROUTED3(AwMessagePortHostMsg_ConvertedWebToAppMessage,
                     int /* recipient message port id */,
                     base::ListValue /* converted message */,
                     std::vector<int> /* sent message port_ids */)
 
 // Response to AwMessagePortMessage_AppToWebMessage
 IPC_MESSAGE_ROUTED3(AwMessagePortHostMsg_ConvertedAppToWebMessage,
                     int /* recipient message port id */,
                     base::string16 /* converted message */,
                     std::vector<int> /* sent message port_ids */)
+
+// Response to AwMessagePortMsg_ClosePort
+IPC_MESSAGE_ROUTED1(AwMessagePortHostMsg_ClosePort,

[nasko, 2015/02/26 17:45:20]

Since this is a response to a message sent from the browser, it is an ack. Let's
add this at the end of the message name - AwMessagePortHostMsg_ClosePortAck.
This is a pattern used in other IPC messages and makes it immediately clear what
the message intent is without looking up its definition.

[sgurun-gerrit only, 2015/02/26 18:00:51]

good point. done.

+                    int /* message port id */)