Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 956753002: Make splash animations abort on scroll. (Closed)

Created:
5 years, 10 months ago by eseidel
Modified:
5 years, 10 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make splash animations abort on scroll. I also fixed the transform hack in material-element to clean up after itself. I also discovered that our namedSetter implementation did not handle null (it crashed) while doing this. I fixed that and tested my fix. This runs great on a Nexus 5, but poorly on an Nexus 10. R=abarth@chromium.org BUG= Committed: https://chromium.googlesource.com/external/mojo/+/6892cfb3342b7c917efb94991ae34e7e43552f1e

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -6 lines) Patch
M sky/engine/bindings/scripts/templates/interface_cpp.template View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/material-element.sky View 1 chunk +34 lines, -2 lines 2 comments Download
M sky/framework/sky-ink-splash.sky View 4 chunks +16 lines, -2 lines 0 comments Download
A sky/tests/styles/inline-style-crash.sky View 1 chunk +28 lines, -0 lines 0 comments Download
A + sky/tests/styles/inline-style-crash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
lgtm
5 years, 10 months ago (2015-02-25 01:16:01 UTC) #1
eseidel
Committed patchset #1 (id:1) manually as 6892cfb3342b7c917efb94991ae34e7e43552f1e (presubmit successful).
5 years, 10 months ago (2015-02-25 01:20:22 UTC) #2
abarth-chromium
5 years, 10 months ago (2015-02-25 02:10:22 UTC) #3
Message was sent while issue was closed.
https://codereview.chromium.org/956753002/diff/1/sky/framework/material-eleme...
File sky/framework/material-element.sky (right):

https://codereview.chromium.org/956753002/diff/1/sky/framework/material-eleme...
sky/framework/material-element.sky:57: for (SkyInkSplash splash in
_activeSplashes) {
It occurs to me that you don't need _activeSplashes.  You can just write:

for (SkyInkSplash splash in shadowRoot.querySelector('sky-ink-splash')) {
  ...
}

https://codereview.chromium.org/956753002/diff/1/sky/framework/material-eleme...
sky/framework/material-element.sky:57: for (SkyInkSplash splash in
_activeSplashes) {
It occurs to me that you don't need _activeSplashes.  You can just write:

for (SkyInkSplash splash in shadowRoot.querySelector('sky-ink-splash')) {
  ...
}

Powered by Google App Engine
This is Rietveld 408576698